-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for Python 3.9 #1026
Conversation
034e68d
to
d56becd
Compare
8ab0d4a
to
5ad0760
Compare
👍 |
@Ryce I can't run the tests locally (they fail en-masse, I've not bothered to work out why) and the Zappa CI isn't working currently. |
Scratch that, tests are passing locally -- but I'd still be happier with Travis confirming that before we merge :) |
Thanks for this! Can't wait to see it pushed |
HI there, we where upgrading our programs to 3.9, but actually found that zappa still doesnt support 3.9, would love to see this land or know an ETA to know if we rollback to 3.8 instead of 3.9 if we can't wait for the date 3.9 support is estimated. |
This comment has been minimized.
This comment has been minimized.
5cedda5
to
4609c26
Compare
Hoping that the troposphere fix for add_description can be included in this PR since the other PR was closed 🤞🏼 |
@ghostmaster-ai so... zappa 1 after this is merged will have support for 3.9, but you suguest it is better to use zappa2? instead? @wrboyce have you send the other PR to zappa2? Im not sure how to proceed here :) |
@tyoc213 this repository is no longer deprecated as a bunch of people, myself included, have come forward to support the project. I have no interest in supporting unofficial forks for the moment. |
I'll delete my branch now that Zappa is un-depricated. I only created zappa2 because I use use Zappa a lot and wanted to continue using it, and I could do that by taking up "maintenance". It's always better to use this repo instead of my zappa2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just had two minor questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it 🚀
Ref https://aws.amazon.com/blogs/compute/python-3-9-runtime-now-available-in-aws-lambda/