Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Python 3.9 #1026

Merged
merged 1 commit into from
Oct 13, 2021
Merged

add support for Python 3.9 #1026

merged 1 commit into from
Oct 13, 2021

Conversation

wrboyce
Copy link
Member

@wrboyce wrboyce commented Aug 17, 2021

@Ryce
Copy link

Ryce commented Sep 1, 2021

👍
Any ETA on this?

@wrboyce
Copy link
Member Author

wrboyce commented Sep 2, 2021

@Ryce I can't run the tests locally (they fail en-masse, I've not bothered to work out why) and the Zappa CI isn't working currently.

@wrboyce
Copy link
Member Author

wrboyce commented Sep 2, 2021

Scratch that, tests are passing locally -- but I'd still be happier with Travis confirming that before we merge :)

@opqpop
Copy link

opqpop commented Sep 6, 2021

Thanks for this! Can't wait to see it pushed

@Ryce
Copy link

Ryce commented Sep 14, 2021

Sorry to keep banging on this one. but could someone have a look?

@Miserlou
@sibblegp
@nikbora
@scoates

@tyoc213
Copy link

tyoc213 commented Sep 17, 2021

HI there, we where upgrading our programs to 3.9, but actually found that zappa still doesnt support 3.9, would love to see this land or know an ETA to know if we rollback to 3.8 instead of 3.9 if we can't wait for the date 3.9 support is estimated.

ghostmaster-ai
ghostmaster-ai previously approved these changes Sep 22, 2021
@ghostmaster-ai

This comment has been minimized.

@willfranklyn
Copy link

willfranklyn commented Sep 27, 2021

Hoping that the troposphere fix for add_description can be included in this PR since the other PR was closed 🤞🏼

@tyoc213
Copy link

tyoc213 commented Sep 27, 2021

@ghostmaster-ai so... zappa 1 after this is merged will have support for 3.9, but you suguest it is better to use zappa2? instead?

@wrboyce have you send the other PR to zappa2?

Im not sure how to proceed here :)

@wrboyce
Copy link
Member Author

wrboyce commented Sep 27, 2021

@tyoc213 this repository is no longer deprecated as a bunch of people, myself included, have come forward to support the project. I have no interest in supporting unofficial forks for the moment.

@ghostmaster-ai
Copy link

@ghostmaster-ai so... zappa 1 after this is merged will have support for 3.9, but you suguest it is better to use zappa2? instead?

@wrboyce have you send the other PR to zappa2?

Im not sure how to proceed here :)

I'll delete my branch now that Zappa is un-depricated. I only created zappa2 because I use use Zappa a lot and wanted to continue using it, and I could do that by taking up "maintenance". It's always better to use this repo instead of my zappa2.

luistm
luistm previously approved these changes Sep 29, 2021
Copy link

@luistm luistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hellno hellno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just had two minor questions

zappa/core.py Show resolved Hide resolved
hellno
hellno previously approved these changes Oct 1, 2021
Copy link
Collaborator

@hellno hellno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants