-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Troposphere library "AttributeError" fix and python3.9 runtime support #1030
Conversation
"add_description" in line 2417 doesn't exists for self.cf_template which is troposphere.Template(). There is "set_description" in troposphere.Template(). Every time while deploying or updating, it generates this error.
Update core.py
support for python3.9 in local and aws
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please 🙏
This would be huge! |
This would be LIT 🔥 |
Yes, please! The old solution we had was to pin tropo to 2.7.0 but the latest major version of setuptools (58.0+) conflicts with troposphere 2.7.0 because setuptools dropped support for |
Thanks for this fix @ghostmaster-ai, I just switched to your fork until a new official release is published |
It isnt the same as this one? #1026 |
Can some one look into this and close the PR? We are stuck with this!!! :( |
Bumps [sqlparse](https://github.com/andialbrecht/sqlparse) from 0.4.1 to 0.4.2. - [Release notes](https://github.com/andialbrecht/sqlparse/releases) - [Changelog](https://github.com/andialbrecht/sqlparse/blob/master/CHANGELOG) - [Commits](andialbrecht/sqlparse@0.4.1...0.4.2) --- updated-dependencies: - dependency-name: sqlparse dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bump sqlparse from 0.4.1 to 0.4.2
Bumps [django](https://github.com/django/django) from 3.1.7 to 3.1.13. - [Release notes](https://github.com/django/django/releases) - [Commits](django/django@3.1.7...3.1.13) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.4 to 1.26.5. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.4...1.26.5) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bump django from 3.1.7 to 3.1.13
Bump urllib3 from 1.26.4 to 1.26.5
… setting SourceAccount when creating lambda resource policy.
fix zappa#1039 prohibit public access to created lambda functions by…
Hey everyone, a team of contributors is back to support the amazing Zappa project. #1026 is the active PR to watch for Python 3.9 support I'm closing this PR as it's not relevant anymore |
Description
zappa/core.py
method "add_description" in core.py line 2417 doesn't exists in the latest troposphere library, method "set_description" takes it's place. This change allows for "zappa deploy" and "zappa update" without errors.
GitHub Issues
#1016
#1002
#1000