Fearless object creation #1034
Merged
Fearless object creation #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
kvark
force-pushed
the
error
branch
3 times, most recently
from
793169b
to
47307b7
Compare
|
bors r+ |
bors bot
added a commit
to gfx-rs/wgpu-rs
that referenced
this pull request
Nov 23, 2020
633: Port to the updated wgpu error model r=scoopr a=kvark Depends on gfx-rs/wgpu#1034 I removed most of the helping sugar we had before, in exchange for simple `match` and a `handle_error` function. I believe this way it's easier to maintain and debug (stepping through closures is a pain today). Co-authored-by: Dzmitry Malyshau <[email protected]>
bors bot
added a commit
that referenced
this pull request
Nov 26, 2020
1050: player: use the wgpu-cores's gfx-select macro r=kvark a=kvark **Connections** Looks like I broke the player in #1034, surprised we didn't notice, and that `cargo test` still passed. The problem was having the `Empty` backend for the device. **Description** Fixes the `device` backend in the player, switches the backend set to be `PRIMARY`, and re-uses the `wgc::gfx-select`. **Testing** Replaying a trace from #1049 Co-authored-by: Dzmitry Malyshau <[email protected]>
bors bot
added a commit
that referenced
this pull request
Nov 26, 2020
1050: player: use the wgpu-cores's gfx-select macro r=kvark a=kvark **Connections** Looks like I broke the player in #1034, surprised we didn't notice, and that `cargo test` still passed. The problem was having the `Empty` backend for the device. **Description** Fixes the `device` backend in the player, switches the backend set to be `PRIMARY`, and re-uses the `wgc::gfx-select`. **Testing** Replaying a trace from #1049 Co-authored-by: Dzmitry Malyshau <[email protected]>
bors bot
added a commit
to gfx-rs/wgpu-native
that referenced
this pull request
Dec 13, 2020
61: Update to latest wgpu-core r=kvark a=DevOrc Updates wgpu-core to [69196d8](gfx-rs/wgpu@69196d8) Notes: - Currently blocked by wgpu-core (see gfx-rs/wgpu#1077) - Updates the error handling as a result of (gfx-rs/wgpu#1034) - set_index_buffer requires an IndexFormat Co-authored-by: Noah Charlton <[email protected]>
bors bot
added a commit
that referenced
this pull request
Mar 23, 2021
1276: Align create_swap_chain function signature r=cwfitzgerald a=kvark **Connections** Follow-up to #1034 **Description** Swapchains are a bit special. Browsers don't use wgpu-core's swapchains, so we never bothered to convert them into the error model. But we still need this for Deno and webgpu-headers. **Testing** Untested, but also harmless Co-authored-by: Dzmitry Malyshau <[email protected]>
bors bot
added a commit
that referenced
this pull request
Mar 23, 2021
1276: Align create_swap_chain function signature r=cwfitzgerald a=kvark **Connections** Follow-up to #1034 **Description** Swapchains are a bit special. Browsers don't use wgpu-core's swapchains, so we never bothered to convert them into the error model. But we still need this for Deno and webgpu-headers. **Testing** Untested, but also harmless Co-authored-by: Dzmitry Malyshau <[email protected]>
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
633: Port to the updated wgpu error model r=scoopr a=kvark Depends on gfx-rs#1034 I removed most of the helping sugar we had before, in exchange for simple `match` and a `handle_error` function. I believe this way it's easier to maintain and debug (stepping through closures is a pain today). Co-authored-by: Dzmitry Malyshau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #977
Fixes #1032
Description
Requiring a separate
xxx_error()is very convenient forwgpu-core, but getting repetitive and complicated for all the users of the API. This PR changes it so we return an object ID unconditionally, and sometimes it's an error. The actual error is passed on the side.Testing
Tested on gfx-rs/wgpu-rs#633