Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge error ID generation into object creation #1032

Closed
kvark opened this issue Nov 19, 2020 · 0 comments · Fixed by #1034
Closed

Merge error ID generation into object creation #1032

kvark opened this issue Nov 19, 2020 · 0 comments · Fixed by #1034
Assignees
@kvark
Labels
area: api Issues related to API surface help required We need community help to make this happen. type: enhancement New feature or request

Comments

@kvark
Copy link
Member

kvark commented Nov 19, 2020

Is your feature request related to a problem? Please describe.
All of the clients today have to go through this pattern where they detect an error generated by create_xxx and they still create an error ID for it with xxx_error. This may be convenient for wgpu-core, but it's not convenient for all the users. Now that we started working on Gecko error model, it would be very useful to streamline this aspect.

Describe the solution you'd like
create_xxx would always return an ID. It may return an optional error in addition to that.

Describe alternatives you've considered
Keep them separate.

Additional context
There seems to be an opportunity to merge this with #985 ?
@kvark kvark added type: enhancement New feature or request help required We need community help to make this happen. area: api Issues related to API surface labels Nov 19, 2020
@kvark kvark pinned this issue Nov 19, 2020
@kvark kvark self-assigned this Nov 20, 2020
@kvark kvark mentioned this issue Nov 20, 2020
Merged
@bors bors bot closed this as completed in #1034 Nov 23, 2020
@bors bors bot closed this as completed in 385ee9f Nov 23, 2020
@kvark kvark unpinned this issue Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvark kvark

Labels
area: api Issues related to API surface help required We need community help to make this happen. type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fearless object creation kvark/wgpu
1 participant
@kvark