Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build status badge #633

Merged
merged 1 commit into from
May 2, 2020
Merged

Fix build status badge #633

merged 1 commit into from
May 2, 2020

Conversation

Gordon-F
Copy link
Contributor

@Gordon-F Gordon-F commented May 2, 2020

fix #630

grovesNL
grovesNL approved these changes May 2, 2020
View reviewed changes
Copy link
Collaborator

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@bors
Copy link
Contributor

bors bot commented May 2, 2020

Build succeeded:

@bors bors bot merged commit 9911115 into gfx-rs:master May 2, 2020
kvark added a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
@bors @kvark
[rs] Merge gfx-rs#633
6f712d5 
633: Port to the updated wgpu error model r=scoopr a=kvark

Depends on gfx-rs#1034

I removed most of the helping sugar we had before, in exchange for simple `match` and a `handle_error` function.
I believe this way it's easier to maintain and debug (stepping through closures is a pain today).

Co-authored-by: Dzmitry Malyshau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grovesNL grovesNL grovesNL approved these changes

@monocodus monocodus[bot] monocodus[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the Readme badges for Github Actions CI
2 participants
@Gordon-F @grovesNL