Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry gradle script refactoring, compatibility with Gradle 5.0 recovered #532

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

OleksandrKucherenko
Copy link
Contributor

Refactoring:

  • sentry cleanup tasks are injected into main clean tasks calls graph. benefits:
  1. cleanup happens when its really forced by user;
  2. caching for upload task will start working; no modifications to input files will be treated by gradle as ability to skip task execution and win us several seconds;
  • logs of the tasks are printed only when gradle --info flag is provided
  • tasks connected to each other now via call graph
  • simplified names of the tasks, bundle task name itself already contains flavor and build type. No need to repeat that
  • tasks declared in our logical group now sentry.io, ./gradlew tasks will display them properly now

resolved issues: #520 and #519

@OleksandrKucherenko
Copy link
Contributor Author

Upload Task in execution graph:

screenshot 2019-01-24 at 13 42 20

Cleanup Tasks in execution graph:
screenshot 2019-01-24 at 13 41 41

@OleksandrKucherenko
Copy link
Contributor Author

Sentry tasks group:

screenshot 2019-01-24 at 13 44 40

@OleksandrKucherenko
Copy link
Contributor Author

@HazAT please review and merge. Will be great to have a gradle 5.0 fix in master

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR, it looks solid, I still need to test it.
Could you please resolve the merge confilict (a PR has been merged that fixed Windows support).

After that I will happily merge the changes.

@OleksandrKucherenko
Copy link
Contributor Author

@HazAT - I rebase the PR and merge all the changes. Should be fine now to merge

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you very much! 🥇

@HazAT HazAT merged commit e98f2c0 into getsentry:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants