Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 5.0 - push() api behaviour changed #519

Closed
OleksandrKucherenko opened this issue Dec 19, 2018 · 1 comment
Closed

Gradle 5.0 - push() api behaviour changed #519

OleksandrKucherenko opened this issue Dec 19, 2018 · 1 comment

Comments

@OleksandrKucherenko
Copy link
Contributor

https://github.com/getsentry/react-native-sentry/blob/96f09af56c6a85e1548acf6fea45be6ef3d44a07/sentry.gradle#L123-L149

What is wrong:
args.push("line") add line in front of the array, but expected add into end.

Details:

Gradle v4.10.2 Exec.arguments: 
[/Users/oleksandr.kucherenko/projects/klarna-app/clients/node_modules/@sentry/cli/bin/sentry-cli, react-native, gradle, --bundle, /Users/oleksandr.kucherenko/projects/klarna-app/clients/android/app/build/generated/assets/react/yellow/release/index.android.bundle, --sourcemap, /Users/oleksandr.kucherenko/projects/klarna-app/clients/android/app/build/generated/assets/react/yellow/release/index.android.bundle.map, --release, net.klarna.app.yellow.int-1.0.0A, --dist, 1]

How arguments array looks in Gradle v5.0:

Gradle v5.0 Exec.arguments: 
[net.klarna.app.yellow.int-1.0.0A, --release, /Users/oleksandr.kucherenko/projects/klarna-app/clients/android/app/build/generated/assets/react/yellow/release/index.android.bundle.map, --sourcemap, /Users/oleksandr.kucherenko/projects/klarna-app/clients/android/app/build/generated/assets/react/yellow/release/index.android.bundle, --bundle, gradle, react-native, /Users/oleksandr.kucherenko/projects/klarna-app/clients/node_modules/@sentry/cli/bin/sentry-cli, --dist, 1]

Solution:

  • replace all push() calls by add() or insert()
@OleksandrKucherenko
Copy link
Contributor Author

@HazAT ^ - can you review the PR and merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant