Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle v5.0 - execute() method renamed to exec() #520

Closed
OleksandrKucherenko opened this issue Dec 19, 2018 · 3 comments
Closed

Gradle v5.0 - execute() method renamed to exec() #520

OleksandrKucherenko opened this issue Dec 19, 2018 · 3 comments

Comments

@OleksandrKucherenko
Copy link
Contributor

https://github.com/getsentry/react-native-sentry/blob/96f09af56c6a85e1548acf6fea45be6ef3d44a07/sentry.gradle#L176-L179

In latest Gradle Exec task has API changes. execute() method is no more available and should be replaced by exec();

Solution:

  • its a wrong approach to call tasks directly from code, gradle has tasks graph and execute tasks according to it. Sentry script should just configure proper dependencies between the tasks and use one of the gradle tasks directives: finalizedBy, mustRunAfter, onlyIf, etc. (https://docs.gradle.org/current/dsl/org.gradle.api.Task.html)
@jussirantala
Copy link

Could you make a PR?

@OleksandrKucherenko
Copy link
Contributor Author

@jussirantala ^

@OleksandrKucherenko
Copy link
Contributor Author

@HazAT ^ - can you review the PR and merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants