fix(replay): Add tests for touch events #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
changed the title
Android (legacy) Performance metrics 🚀
|
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 41db11d+dirty | 374.57 ms | 415.25 ms | 40.68 ms |
| 376301c+dirty | 353.80 ms | 388.54 ms | 34.74 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 41db11d+dirty | 7.15 MiB | 8.31 MiB | 1.16 MiB |
| 376301c+dirty | 7.15 MiB | 8.31 MiB | 1.17 MiB |
Previous results on branch: kw/replay-touch-events-tests
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bb8c974+dirty | 442.73 ms | 455.33 ms | 12.60 ms |
| b91c34b+dirty | 446.16 ms | 490.98 ms | 44.82 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bb8c974+dirty | 7.15 MiB | 8.31 MiB | 1.17 MiB |
| b91c34b+dirty | 7.15 MiB | 8.31 MiB | 1.17 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 41db11d+dirty | 1207.36 ms | 1210.32 ms | 2.96 ms |
| 376301c+dirty | 1215.73 ms | 1219.80 ms | 4.06 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 41db11d+dirty | 2.36 MiB | 3.04 MiB | 698.69 KiB |
| 376301c+dirty | 2.36 MiB | 3.05 MiB | 702.83 KiB |
Previous results on branch: kw/replay-touch-events-tests
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b91c34b+dirty | 1228.65 ms | 1223.80 ms | -4.86 ms |
| bb8c974+dirty | 1224.91 ms | 1230.04 ms | 5.13 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b91c34b+dirty | 2.36 MiB | 3.05 MiB | 702.76 KiB |
| bb8c974+dirty | 2.36 MiB | 3.05 MiB | 702.79 KiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 41db11d+dirty | 1208.60 ms | 1210.47 ms | 1.87 ms |
| 376301c+dirty | 1224.74 ms | 1227.00 ms | 2.26 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 41db11d+dirty | 2.92 MiB | 3.61 MiB | 705.84 KiB |
| 376301c+dirty | 2.92 MiB | 3.61 MiB | 709.95 KiB |
Previous results on branch: kw/replay-touch-events-tests
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b91c34b+dirty | 1230.57 ms | 1221.62 ms | -8.95 ms |
| bb8c974+dirty | 1222.94 ms | 1216.53 ms | -6.41 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b91c34b+dirty | 2.92 MiB | 3.61 MiB | 709.85 KiB |
| bb8c974+dirty | 2.92 MiB | 3.61 MiB | 709.85 KiB |
krystofwoldrich
force-pushed
the
kw/replay-touch-events-tests
branch
from
bcec1bd to
9f7aa6e
Compare
krystofwoldrich
changed the base branch from
kw/add-sentry-babel-transaformer
to
feat/replay
vaind
approved these changes
Jul 1, 2024
bruno-garcia
added a commit
that referenced
this pull request
Jul 15, 2024
* feat(replay): Add Mobile Replay Alpha (#3714) * feat(sample): add running indicator (animation overlay) (#3903) * feat(replay): Add breadcrumbs mapping from RN to RRWeb format (#3846) * feat(replay): Add network breadcrumbs (#3912) * fix(replay): Add tests for touch events (#3924) * feat(replay): Filter Sentry event breadcrumbs (#3925) * fix(changelog): Add latest native SDKs details * release: 5.25.0-alpha.2 * misc(samples): Add console anything examples for replay testing (#3928) * feat: Add Sentry Babel Transformer (#3916) * fix(replay): Add app lifecycle breadcrumbs conversion tests (#3932) * chore(deps): bump sentry-android to 7.12.0-alpha.3 * chore(deps): bump sentry-android to 7.12.0-alpha.4 * fix(replay): Mask SVGs from `react-native-svg` when `maskAllVectors=true` (#3930) * fix(replay): Add missing properties to android nav breadcrumbs (#3942) * release: 5.26.0-alpha.3 * misc(replay): Add Mobile Replay Public Beta changelog (#3943) --------- Co-authored-by: Ivan Dlugos <[email protected]> Co-authored-by: Ivan Dlugos <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: Roman Zavarnitsyn <[email protected]> Co-authored-by: Bruno Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR adds tests for native replay touch breadcrumbs conversions and fixes an issue with labeled touch without name which caused crash on iOS and null label on Android. (this was not release so no users were impacted)
💚 How did you test it?
sample app, unit tests
📝 Checklist
sendDefaultPIIis enabled#skip-changelog