Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replay): Add Mobile Replay #3830

Merged
merged 29 commits into from
Jul 15, 2024
Merged

feat(replay): Add Mobile Replay #3830

merged 29 commits into from
Jul 15, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented May 21, 2024 •
edited
Loading

Only Reviewed Content from other PRs in this branch

This PR contains all the changes needed for RN Mobile Replay.

Future alphas and betas should be also released from this branch.

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b9a7f9d

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 409.52 ms 460.44 ms 50.92 ms
Size 17.73 MiB 20.05 MiB 2.31 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
34aba08 328.10 ms 342.84 ms 14.74 ms
d7401ac+dirty 375.20 ms 383.51 ms 8.31 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
80b2ce3 385.02 ms 387.36 ms 2.34 ms
22e31b6 396.48 ms 419.64 ms 23.16 ms
5446992 403.40 ms 426.70 ms 23.30 ms
ad6c299 375.94 ms 382.02 ms 6.08 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
728164b 414.34 ms 449.22 ms 34.88 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms

App size

Revision Plain With Sentry Diff
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
d7401ac+dirty 17.73 MiB 19.75 MiB 2.02 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
80b2ce3 17.73 MiB 19.75 MiB 2.02 MiB
22e31b6 17.73 MiB 19.84 MiB 2.10 MiB
5446992 17.73 MiB 19.85 MiB 2.12 MiB
ad6c299 17.73 MiB 19.75 MiB 2.02 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
728164b 17.73 MiB 19.85 MiB 2.12 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB

Previous results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
41db11d 429.33 ms 451.24 ms 21.91 ms
376301c 445.52 ms 474.70 ms 29.18 ms
6b9147b 431.40 ms 448.40 ms 17.00 ms
52f5e03 422.50 ms 465.69 ms 43.19 ms
063bfce 469.96 ms 516.38 ms 46.42 ms
c3e4705 478.62 ms 486.84 ms 8.22 ms

App size

Revision Plain With Sentry Diff
41db11d 17.73 MiB 20.04 MiB 2.30 MiB
376301c 17.73 MiB 20.04 MiB 2.30 MiB
6b9147b 17.73 MiB 20.04 MiB 2.31 MiB
52f5e03 17.73 MiB 20.04 MiB 2.31 MiB
063bfce 17.73 MiB 20.04 MiB 2.30 MiB
c3e4705 17.73 MiB 20.05 MiB 2.31 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 432.04 ms 467.82 ms 35.78 ms
Size 7.15 MiB 8.32 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d7401ac+dirty 373.98 ms 394.08 ms 20.10 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
e5c9b8b+dirty 335.40 ms 360.06 ms 24.67 ms
b1e8712+dirty 322.55 ms 331.84 ms 9.29 ms
2534337+dirty 597.14 ms 665.04 ms 67.90 ms
1c65324+dirty 381.10 ms 427.26 ms 46.16 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
9c48b2c+dirty 270.82 ms 321.12 ms 50.30 ms
9433f35+dirty 265.50 ms 336.08 ms 70.58 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms

App size

Revision Plain With Sentry Diff
d7401ac+dirty 7.15 MiB 8.04 MiB 910.85 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
e5c9b8b+dirty 7.15 MiB 8.10 MiB 980.41 KiB
b1e8712+dirty 7.15 MiB 8.04 MiB 912.27 KiB
2534337+dirty 7.15 MiB 8.11 MiB 988.68 KiB
1c65324+dirty 7.15 MiB 8.22 MiB 1.07 MiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
9c48b2c+dirty 7.15 MiB 8.07 MiB 947.16 KiB
9433f35+dirty 7.15 MiB 8.08 MiB 959.34 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB

Previous results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
6b9147b+dirty 384.48 ms 457.15 ms 72.67 ms
063bfce+dirty 338.00 ms 369.88 ms 31.88 ms
c3e4705+dirty 391.08 ms 461.04 ms 69.96 ms
376301c+dirty 353.80 ms 388.54 ms 34.74 ms
52f5e03+dirty 391.15 ms 446.94 ms 55.79 ms
41db11d+dirty 374.57 ms 415.25 ms 40.68 ms

App size

Revision Plain With Sentry Diff
6b9147b+dirty 7.15 MiB 8.32 MiB 1.17 MiB
063bfce+dirty 7.15 MiB 8.31 MiB 1.17 MiB
c3e4705+dirty 7.15 MiB 8.32 MiB 1.17 MiB
376301c+dirty 7.15 MiB 8.31 MiB 1.17 MiB
52f5e03+dirty 7.15 MiB 8.32 MiB 1.17 MiB
41db11d+dirty 7.15 MiB 8.31 MiB 1.16 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 18, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.81 ms 1226.12 ms 3.31 ms
Size 2.36 MiB 3.06 MiB 717.48 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
9433f35+dirty 1246.94 ms 1271.45 ms 24.52 ms
4a6664f+dirty 1209.49 ms 1208.63 ms -0.86 ms
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
dadc233+dirty 1223.20 ms 1236.88 ms 13.68 ms
f06c879+dirty 1252.64 ms 1259.66 ms 7.02 ms
5a22220+dirty 1209.49 ms 1220.94 ms 11.45 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms

App size

Revision Plain With Sentry Diff
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
9433f35+dirty 2.36 MiB 2.85 MiB 499.80 KiB
4a6664f+dirty 2.36 MiB 3.04 MiB 696.39 KiB
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
dadc233+dirty 2.36 MiB 2.84 MiB 486.85 KiB
f06c879+dirty 2.36 MiB 2.88 MiB 530.42 KiB
5a22220+dirty 2.36 MiB 2.92 MiB 570.21 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB

Previous results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
52f5e03+dirty 1221.27 ms 1223.08 ms 1.81 ms
376301c+dirty 1215.73 ms 1219.80 ms 4.06 ms
41db11d+dirty 1207.36 ms 1210.32 ms 2.96 ms
6b9147b+dirty 1220.55 ms 1219.22 ms -1.33 ms
c3e4705+dirty 1207.77 ms 1214.63 ms 6.87 ms
063bfce+dirty 1224.27 ms 1219.66 ms -4.61 ms

App size

Revision Plain With Sentry Diff
52f5e03+dirty 2.36 MiB 3.05 MiB 703.38 KiB
376301c+dirty 2.36 MiB 3.05 MiB 702.83 KiB
41db11d+dirty 2.36 MiB 3.04 MiB 698.69 KiB
6b9147b+dirty 2.36 MiB 3.06 MiB 717.37 KiB
c3e4705+dirty 2.36 MiB 3.06 MiB 717.36 KiB
063bfce+dirty 2.36 MiB 3.05 MiB 702.78 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 18, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1249.08 ms 1245.08 ms -4.00 ms
Size 2.92 MiB 3.62 MiB 718.61 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
86d6d2c+dirty 1291.62 ms 1296.80 ms 5.18 ms
e2b64fe+dirty 1285.78 ms 1297.56 ms 11.78 ms
9433f35+dirty 1232.24 ms 1232.74 ms 0.50 ms
4a6664f+dirty 1218.77 ms 1221.07 ms 2.30 ms
80b2ce3+dirty 1245.12 ms 1262.04 ms 16.92 ms
dadc233+dirty 1266.52 ms 1282.55 ms 16.03 ms
f06c879+dirty 1285.14 ms 1285.86 ms 0.72 ms
5a22220+dirty 1246.18 ms 1249.61 ms 3.43 ms
3853f43+dirty 1271.74 ms 1278.04 ms 6.30 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms

App size

Revision Plain With Sentry Diff
86d6d2c+dirty 2.92 MiB 3.37 MiB 464.31 KiB
e2b64fe+dirty 2.92 MiB 3.41 MiB 499.97 KiB
9433f35+dirty 2.92 MiB 3.41 MiB 503.55 KiB
4a6664f+dirty 2.92 MiB 3.60 MiB 702.09 KiB
80b2ce3+dirty 2.92 MiB 3.40 MiB 492.75 KiB
dadc233+dirty 2.92 MiB 3.40 MiB 492.53 KiB
f06c879+dirty 2.92 MiB 3.44 MiB 533.24 KiB
5a22220+dirty 2.92 MiB 3.48 MiB 575.81 KiB
3853f43+dirty 2.92 MiB 3.41 MiB 503.54 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB

Previous results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
52f5e03+dirty 1227.53 ms 1231.76 ms 4.22 ms
376301c+dirty 1224.74 ms 1227.00 ms 2.26 ms
41db11d+dirty 1208.60 ms 1210.47 ms 1.87 ms
6b9147b+dirty 1239.65 ms 1233.69 ms -5.97 ms
c3e4705+dirty 1221.81 ms 1226.51 ms 4.70 ms
063bfce+dirty 1225.38 ms 1218.06 ms -7.31 ms

App size

Revision Plain With Sentry Diff
52f5e03+dirty 2.92 MiB 3.61 MiB 710.43 KiB
376301c+dirty 2.92 MiB 3.61 MiB 709.95 KiB
41db11d+dirty 2.92 MiB 3.61 MiB 705.84 KiB
6b9147b+dirty 2.92 MiB 3.62 MiB 718.74 KiB
c3e4705+dirty 2.92 MiB 3.62 MiB 718.72 KiB
063bfce+dirty 2.92 MiB 3.61 MiB 710.22 KiB

krystofwoldrich and others added 18 commits June 21, 2024 10:04
@krystofwoldrich
feat(sample): add running indicator (animation overlay) (#3903)
13a9360
@vaind
Merge branch 'main' into feat/replay
1f1e41e
@vaind
feat(replay): Add breadcrumbs mapping from RN to RRWeb format (#3846)
38d8d7c
@krystofwoldrich
feat(replay): Add network breadcrumbs (#3912)
ac72abc
@krystofwoldrich
fix(replay): Add tests for touch events (#3924)
5f3a5c8
@krystofwoldrich
feat(replay): Filter Sentry event breadcrumbs (#3925)
b4aaa68
@krystofwoldrich
Merge branch 'main' into feat/replay
00aa520
@krystofwoldrich
fix(changelog): Add latest native SDKs details
cfd5aee
@getsentry-bot
release: 5.25.0-alpha.2
83f5a0c
Merge branch 'release/5.25.0-alpha.2' into feat/replay
8e9c3a0
@krystofwoldrich
misc(samples): Add console anything examples for replay testing (#3928)
9672e88
@krystofwoldrich
feat: Add Sentry Babel Transformer (#3916)
6067ecc
@krystofwoldrich
fix(replay): Add app lifecycle breadcrumbs conversion tests (#3932)
3b28c40
@krystofwoldrich
Merge remote-tracking branch 'origin/main' into feat/replay
e25da10
@krystofwoldrich
chore(deps): bump sentry-android to 7.12.0-alpha.3
6d8c4dd
@krystofwoldrich
chore(deps): bump sentry-android to 7.12.0-alpha.4
6fd2a34
@krystofwoldrich
fix(replay): Mask SVGs from react-native-svg when `maskAllVectors=t…
3dcf57b 
…rue` (#3930)
@krystofwoldrich
Merge remote-tracking branch 'origin/main' into feat/replay
361867e
lucas-zimerman
lucas-zimerman reviewed Jul 11, 2024
View reviewed changes
android/build.gradle Outdated
@@ -54,5 +54,5 @@ android {

dependencies {
implementation 'com.facebook.react:react-native:+'
api 'io.sentry:sentry-android:7.11.0'
api 'io.sentry:sentry-android:7.12.0-alpha.4'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: do you need to use this alpha release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will wait for stable release. Should be this Friday.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stable versions are out

lucas-zimerman
lucas-zimerman reviewed Jul 11, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
lucas-zimerman
lucas-zimerman reviewed Jul 11, 2024
View reviewed changes
src/js/version.ts Outdated Show resolved Hide resolved
lucas-zimerman
lucas-zimerman approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor questions in regard versioning, but other than that it is not blocking if we change it or not so I am approving it :D

@krystofwoldrich
Copy link
Member Author

The 5.25.0-alpha.2 is the latest version of Sentry's RN SDK with Session Replay, that's why it's in the branch, craft will overwrite it with a new version when we release it.

The Android Session Replay (Beta) will be released on Friday in a stable release of the Android SDK and we will release RN with that.

@lucas-zimerman
Copy link
Collaborator

Added a blocked label to remind that we should wait for non beta releases from the native SDKs to be released before merging.

@bruno-garcia bruno-garcia marked this pull request as ready for review July 15, 2024 20:43
@bruno-garcia bruno-garcia merged commit 9421616 into main Jul 15, 2024
61 checks passed
@bruno-garcia bruno-garcia deleted the feat/replay branch July 15, 2024 21:22
@bruno-garcia bruno-garcia mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia left review comments

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@krystofwoldrich @lucas-zimerman @bruno-garcia @vaind @getsentry-bot @romtsn