Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sample): add running indicator (animation overlay) #3903

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Jun 19, 2024

📢 Type of change

  • Enhancement

📜 Description

This PR adds a simple spining animation to help Replay debugging.

Screen Recording 2024-06-19 at 14 21 29

example replay

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

#skip-changelog

@krystofwoldrich krystofwoldrich changed the title Kw/add-running-animation feat(sample): add running indicator (animation overlay) Jun 19, 2024
Copy link
Contributor

github-actions bot commented Jun 19, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 23ac1d8

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

github-actions bot commented Jun 19, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.17 ms 1222.84 ms 2.67 ms
Size 2.36 MiB 3.04 MiB 698.77 KiB

Baseline results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
41db11d+dirty 1207.36 ms 1210.32 ms 2.96 ms

App size

Revision Plain With Sentry Diff
41db11d+dirty 2.36 MiB 3.04 MiB 698.69 KiB

Copy link
Contributor

github-actions bot commented Jun 19, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 442.23 ms 480.55 ms 38.32 ms
Size 17.73 MiB 20.04 MiB 2.30 MiB

Baseline results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
41db11d 429.33 ms 451.24 ms 21.91 ms

App size

Revision Plain With Sentry Diff
41db11d 17.73 MiB 20.04 MiB 2.30 MiB

Copy link
Contributor

github-actions bot commented Jun 19, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 391.29 ms 441.00 ms 49.71 ms
Size 7.15 MiB 8.31 MiB 1.16 MiB

Baseline results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
41db11d+dirty 374.57 ms 415.25 ms 40.68 ms

App size

Revision Plain With Sentry Diff
41db11d+dirty 7.15 MiB 8.31 MiB 1.16 MiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1216.93 ms 1218.49 ms 1.56 ms
Size 2.92 MiB 3.61 MiB 705.80 KiB

Baseline results on branch: feat/replay

Startup times

Revision Plain With Sentry Diff
41db11d+dirty 1208.60 ms 1210.47 ms 1.87 ms

App size

Revision Plain With Sentry Diff
41db11d+dirty 2.92 MiB 3.61 MiB 705.84 KiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich krystofwoldrich merged commit 13a9360 into feat/replay Jun 21, 2024
6 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/add-running-animation branch June 21, 2024 08:04
bruno-garcia added a commit that referenced this pull request Jul 15, 2024
* feat(replay): Add Mobile Replay Alpha (#3714)

* feat(sample): add running indicator (animation overlay) (#3903)

* feat(replay): Add breadcrumbs mapping from RN to RRWeb format (#3846)

* feat(replay): Add network breadcrumbs (#3912)

* fix(replay): Add tests for touch events (#3924)

* feat(replay): Filter Sentry event breadcrumbs (#3925)

* fix(changelog): Add latest native SDKs details

* release: 5.25.0-alpha.2

* misc(samples): Add console anything examples for replay testing (#3928)

* feat: Add Sentry Babel Transformer (#3916)

* fix(replay): Add app lifecycle breadcrumbs conversion tests (#3932)

* chore(deps): bump sentry-android to 7.12.0-alpha.3

* chore(deps): bump sentry-android to 7.12.0-alpha.4

* fix(replay): Mask SVGs from `react-native-svg` when `maskAllVectors=true` (#3930)

* fix(replay): Add missing properties to android nav breadcrumbs (#3942)

* release: 5.26.0-alpha.3

* misc(replay): Add Mobile Replay Public Beta changelog (#3943)

---------

Co-authored-by: Ivan Dlugos <[email protected]>
Co-authored-by: Ivan Dlugos <[email protected]>
Co-authored-by: getsentry-bot <[email protected]>
Co-authored-by: getsentry-bot <[email protected]>
Co-authored-by: Roman Zavarnitsyn <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants