Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clean up sentry requested sourcemap #327

Merged
merged 1 commit into from
Jan 12, 2018
Merged

fix: Clean up sentry requested sourcemap #327

merged 1 commit into from
Jan 12, 2018

Conversation

dr-js
Copy link

@dr-js dr-js commented Jan 12, 2018

Sentry requested sourcemap (like for release bundle) should be auto deleted after upload is complete.

For our usage, the resulting release.apk is ~1MB smaller, except with an extra line in \assets\index.android.bundle:

//# sourceMappingURL=index.android.bundle.map

Sentry requested sourcemap (like for release bundle) should be auto deleted after upload is complete.
@dr-js dr-js requested a review from HazAT as a code owner January 12, 2018 08:01
@HazAT
Copy link
Member

HazAT commented Jan 12, 2018

Thank you for this awesome fix/feature :)

@HazAT HazAT merged commit 2392a6d into getsentry:master Jan 12, 2018
@AndreTsao
Copy link

Why not to delete the sourcemaps upon successful upload by default in ios?
I think it's a basic feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants