Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clean up sentry requested sourcemap #327

Merged
merged 1 commit into from
Jan 12, 2018
Merged

fix: Clean up sentry requested sourcemap #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions sentry.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ gradle.projectsEvaluated {
def bundleOutput = null;
def sourcemapOutput = null;
def reactRoot = props.get("workingDir");
def shouldCleanUp = false;

cmdArgs.eachWithIndex{ String arg, int i ->
if (arg == "--bundle-output") {
Expand All @@ -42,6 +43,8 @@ gradle.projectsEvaluated {
cmd.push(sourcemapOutput);
cmdArgs.push("--sourcemap-output");
cmdArgs.push(sourcemapOutput);

shouldCleanUp = true
}

bundleTask.setProperty("commandLine", cmd);
Expand Down Expand Up @@ -150,8 +153,19 @@ gradle.projectsEvaluated {
enabled true
}

def cliCleanUpTask = tasks.create(
name: bundleTask.getName() + variant + "SentryUploadCleanUp",
type: Delete) {
description = "clean up extra sourcemap"

delete sourcemapOutput
};

bundleTask.doLast {
cliTask.execute();
if (shouldCleanUp) {
cliCleanUpTask.execute();
}
}

cliTask.dependsOn(bundleTask)
Expand Down