Skip to content

Commit

Permalink
fix: Clean up sentry requested sourcemap (#327)
Browse files Browse the repository at this point in the history
Sentry requested sourcemap (like for release bundle) should be auto deleted after upload is complete.
  • Loading branch information
Dr authored and HazAT committed Jan 12, 2018
1 parent bdb1802 commit 2392a6d
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions sentry.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ gradle.projectsEvaluated {
def bundleOutput = null;
def sourcemapOutput = null;
def reactRoot = props.get("workingDir");
def shouldCleanUp = false;

cmdArgs.eachWithIndex{ String arg, int i ->
if (arg == "--bundle-output") {
Expand All @@ -42,6 +43,8 @@ gradle.projectsEvaluated {
cmd.push(sourcemapOutput);
cmdArgs.push("--sourcemap-output");
cmdArgs.push(sourcemapOutput);

shouldCleanUp = true
}

bundleTask.setProperty("commandLine", cmd);
Expand Down Expand Up @@ -150,8 +153,19 @@ gradle.projectsEvaluated {
enabled true
}

def cliCleanUpTask = tasks.create(
name: bundleTask.getName() + variant + "SentryUploadCleanUp",
type: Delete) {
description = "clean up extra sourcemap"

delete sourcemapOutput
};

bundleTask.doLast {
cliTask.execute();
if (shouldCleanUp) {
cliCleanUpTask.execute();
}
}

cliTask.dependsOn(bundleTask)
Expand Down

0 comments on commit 2392a6d

Please sign in to comment.