Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2.0.0 not building with use_frameworks #1171

Closed
5 of 11 tasks
Almouro opened this issue Nov 4, 2020 · 4 comments
Closed
5 of 11 tasks

Version 2.0.0 not building with use_frameworks #1171

Almouro opened this issue Nov 4, 2020 · 4 comments
Labels
Type: 🪲 Bug

Comments

@Almouro
Copy link

Almouro commented Nov 4, 2020

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

SDK:

  • @sentry/react-native (>= 1.0.0)
  • react-native-sentry (<= 0.43.2)

SDK version: 2.0.0

react-native version: 0.63.3

Are you using Expo?

  • Yes
  • No

Are you using sentry.io or on-premise?

  • sentry.io (SaaS)
  • on-premise

If you are using sentry.io, please post a link to your issue so we can take a look:

Not relevant

Configuration:

Not relevant

I have following issue:

When using use_frameworks! in the Podfile, I can't build RNSentry and get the following error:

Steps to reproduce:

  • react-native init TestSentry
  • Add use_frameworks! in Podfile (which produces The 'Pods-TestSentry' target has transitive dependencies that include statically linked binaries error when running pod install)
  • Add this workardound in the Podfile to make pod install work:
pre_install do |installer|
  # See https://github.com/CocoaPods/CocoaPods/issues/3289
  Pod::Installer::Xcode::TargetValidator.send(
    :define_method,
    :verify_no_static_framework_transitive_dependencies
  ) {}
end

Actual result:

Getting this error: 'Sentry/SentryFileManager.h' file not found when building the app

Perhaps should the file be added into this folder on sentry-cocoa? https://github.com/getsentry/sentry-cocoa/tree/master/Sources/Sentry/Public

Previous version of the SDK is building fine however

Expected result:

The app should bulld
@jennmueng jennmueng mentioned this issue Nov 8, 2020
Closed
6 tasks
@jennmueng jennmueng mentioned this issue Nov 8, 2020
Closed
5 tasks
@jennmueng
Copy link
Member

The fix has been introduced in this PR to @sentry/cocoa getsentry/sentry-cocoa#835

@hanayashiki
Copy link

Looking forward to the update!

philipphofmann added a commit to getsentry/sentry-cocoa that referenced this issue Nov 9, 2020
@philipphofmann
feat: Add storeEnvelope on SentryClient
ea5db28 
Hybrid SDKs as react-native need a way to synchronously store an envelope to disk. Previously, this
was possible by exposing SentryFileManager on the SentryClient, but this breaks users of
react-native that use use_frameworks!,
see getsentry/sentry-react-native#1171. A way to fix this would be to expose
SentryFileManager and SentryCurrentDateProvider as proposed in
#835. This has the downside of making classes public,
that shouldn't be public. A better workaround is to expose storeEnvelope on the SentryClient.
philipphofmann added a commit to getsentry/sentry-cocoa that referenced this issue Nov 9, 2020
@philipphofmann
feat: Add storeEnvelope on SentryClient
6470962 
Hybrid SDKs as react-native need a way to synchronously store an envelope to disk. Previously, this
was possible by exposing SentryFileManager on the SentryClient, but this breaks users of
react-native that use use_frameworks!,
see getsentry/sentry-react-native#1171. A way to fix this would be to expose
SentryFileManager and SentryCurrentDateProvider as proposed in
#835. This has the downside of making classes public,
that shouldn't be public. A better workaround is to expose storeEnvelope on the SentryClient.
@philipphofmann philipphofmann mentioned this issue Nov 9, 2020
Merged
5 tasks
philipphofmann added a commit to getsentry/sentry-cocoa that referenced this issue Nov 10, 2020
@philipphofmann
feat: Add storeEnvelope on SentryClient (#836)
c34b906 
Hybrid SDKs as react-native need a way to synchronously store an envelope to disk. Previously, this
was possible by exposing SentryFileManager on the SentryClient, but this breaks users of
react-native that use use_frameworks!,
see getsentry/sentry-react-native#1171. A way to fix this would be to expose
SentryFileManager and SentryCurrentDateProvider as proposed in
#835. This has the downside of making classes public,
that shouldn't be public. A better workaround is to expose storeEnvelope on the SentryClient.
@jennmueng jennmueng mentioned this issue Nov 12, 2020
Merged
8 tasks
@jennmueng
Copy link
Member

This issue has been fixed in version 2.0.1. Please upgrade and don't forget to run pod install!

@Almouro
Copy link
Author

Almouro commented Nov 26, 2020

Thanks @jennmueng ! Works well now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: 🪲 Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Almouro @hanayashiki @jennmueng