feat: Expose SentryFileManager and SentryCurrentDateProvider #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
jennmueng
requested review from
bruno-garcia,
HazAT and
philipphofmann
as code owners
|
If I'm not mistaken react-native only needs |
|
Hmm, we could also do that, but let's just add it to the |
philipphofmann
added a commit
that referenced
this pull request
Nov 9, 2020
Hybrid SDKs as react-native need a way to synchronously store an envelope to disk. Previously, this was possible by exposing SentryFileManager on the SentryClient, but this breaks users of react-native that use use_frameworks!, see getsentry/sentry-react-native#1171. A way to fix this would be to expose SentryFileManager and SentryCurrentDateProvider as proposed in #835. This has the downside of making classes public, that shouldn't be public. A better workaround is to expose storeEnvelope on the SentryClient.
philipphofmann
added a commit
that referenced
this pull request
Nov 9, 2020
Hybrid SDKs as react-native need a way to synchronously store an envelope to disk. Previously, this was possible by exposing SentryFileManager on the SentryClient, but this breaks users of react-native that use use_frameworks!, see getsentry/sentry-react-native#1171. A way to fix this would be to expose SentryFileManager and SentryCurrentDateProvider as proposed in #835. This has the downside of making classes public, that shouldn't be public. A better workaround is to expose storeEnvelope on the SentryClient.
5 tasks
|
Suggested change opened in #836 |
philipphofmann
added a commit
that referenced
this pull request
Nov 10, 2020
Hybrid SDKs as react-native need a way to synchronously store an envelope to disk. Previously, this was possible by exposing SentryFileManager on the SentryClient, but this breaks users of react-native that use use_frameworks!, see getsentry/sentry-react-native#1171. A way to fix this would be to expose SentryFileManager and SentryCurrentDateProvider as proposed in #835. This has the downside of making classes public, that shouldn't be public. A better workaround is to expose storeEnvelope on the SentryClient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Expose
SentryFileManager.handSentryCurrentDateProvider.hto be public as@sentry/react-nativeuses them.💡 Motivation and Context
Directly importing private header files caused issued for users that use
use_frameworks!in their Podfile: getsentry/sentry-react-native#1171💚 How did you test it?
Linked to this branch locally with our react native sample app and confirmed that the issue is gone when using
use_frameworks!.📝 Checklist
🔮 Next steps
Corresponding PR for React Native to follow that no longer directly imports these header files.