Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): Bump sentry-cocoa to 6.0.8 and remove private imports #1188

Merged
merged 5 commits into from
Nov 16, 2020

Conversation

jennmueng
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Remove private imports from sentry-cocoa and call storeEnvelope on the client instead of through fileManager like before.

💡 Motivation and Context

Users were having issues with use_frameworks! in their Podfile.
#1171

💚 How did you test it?

Confirmed that the app builds with the use_frameworks! tag in the Podfile. Tested that unhandled fatal errors are still stored and sent as needed.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

ios/RNSentry.m Outdated Show resolved Hide resolved
@jennmueng jennmueng merged commit 97b16b7 into master Nov 16, 2020
@jennmueng jennmueng deleted the fix/use-frameworks branch November 16, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants