Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(ember): Allow initing Ember without config entry #3745

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Jun 24, 2021

Summary

Using the config is only necessary if you want to change specific addon options now, and the docs are going to be updated to reflect this. Passing a config object to should work without a config entry for sentry.

Using the config is only necessary if you want to change specific addon options now, and the docs are going to be updated to reflect this. Passing a config object to  should work without a config entry for sentry.
@k-fish k-fish requested a review from kamilogorek as a code owner June 24, 2021 15:37
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.01 KB (-0.01% 🔽)
@sentry/browser - Webpack 21.95 KB (0%)
@sentry/react - Webpack 21.99 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.42 KB (-0.01% 🔽)

@HazAT HazAT merged commit 0b42582 into master Jun 25, 2021
@HazAT HazAT deleted the ref/ember-fix-init-for-runtime-config-only branch June 25, 2021 07:19
1999 added a commit to 1999/sentry-javascript that referenced this pull request Jun 25, 2021
…transport

* upstream/master: (29 commits)
  ref: Always use lowercase files (getsentry#3742)
  feat: Make dedupe integration default for browser (getsentry#3730)
  ref(ember): Allow initing Ember without config entry (getsentry#3745)
  fix(serverless): wrapEventFunction does not await for async code (getsentry#3740)
  Metrics: Tag CLS elements (getsentry#3734)
  feat: Add Next.js 11 to supported peer dependencies list (getsentry#3711)
  test: Run integration tests for Next 10/11 and Webpack 4/5 matrix (getsentry#3741)
  fix: Correctly limit Buffer requests (getsentry#3736)
  Whoops. Remove pinned node version from package.json
  ref: Introduce test runner for node session health tests (getsentry#3728)
  fix: Prevent circular structure serialization in events (getsentry#3727)
  ref(node): Update Node manual tests and test for sessionCount (getsentry#3726)
  ref(ember): Update scenarios and remove a few to speed up tests (getsentry#3720)
  docs: Fix typos (getsentry#3716)
  fix(ember): Fix ember test flake (getsentry#3719)
  release: 6.7.2
  ci: fix ember flaky test (getsentry#3718)
  misc: changelog for release 6.7.2 (getsentry#3717)
  fix(release-health): Prevent sending terminal status session updates (getsentry#3701)
  ref: Make beforeSend more strict (getsentry#3713)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants