fix(serverless): wrapEventFunction does not await for async code #3740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedetefy
force-pushed
the
ahmed-fix-serverless-gcp-async
branch
from
5583570 to
ab3e6e4
Compare
ahmedetefy
changed the title
size-limit report
|
Closed
3 tasks
kamilogorek
reviewed
Jun 24, 2021
| .then(() => (fn as CloudEventFunction)(context)) | ||
| .then( | ||
| result => { | ||
| newCallback(null, result); | ||
| return newCallback(null, result); |
There was a problem hiding this comment.
if we write result => newCallback(null, result) prettier should format it nicely
kamilogorek
approved these changes
Jun 24, 2021
| @@ -72,14 +72,14 @@ function _wrapCloudEventFunction( | |||
| return (fn as CloudEventFunctionWithCallback)(context, newCallback); | |||
| } | |||
|
|
|||
| void Promise.resolve() | |||
| return Promise.resolve() | |||
There was a problem hiding this comment.
Has this fix been tested on GCP using the example that @killthekitten provided in the example?
My only concern with this is that the top level function i.e. L37 is returning a non-asynchronous function to the GCP runner, so the promises within the function might not be correctly resolved within the runners lifecycle? (I might be wrong)
If my above concern is valid, it would be helpful to have the following expectations in the tests:
expect(wrappedHandler).toBeInstanceOf(Promise);
1999
added a commit
to 1999/sentry-javascript
that referenced
this pull request
Jun 25, 2021
…transport * upstream/master: (29 commits) ref: Always use lowercase files (getsentry#3742) feat: Make dedupe integration default for browser (getsentry#3730) ref(ember): Allow initing Ember without config entry (getsentry#3745) fix(serverless): wrapEventFunction does not await for async code (getsentry#3740) Metrics: Tag CLS elements (getsentry#3734) feat: Add Next.js 11 to supported peer dependencies list (getsentry#3711) test: Run integration tests for Next 10/11 and Webpack 4/5 matrix (getsentry#3741) fix: Correctly limit Buffer requests (getsentry#3736) Whoops. Remove pinned node version from package.json ref: Introduce test runner for node session health tests (getsentry#3728) fix: Prevent circular structure serialization in events (getsentry#3727) ref(node): Update Node manual tests and test for sessionCount (getsentry#3726) ref(ember): Update scenarios and remove a few to speed up tests (getsentry#3720) docs: Fix typos (getsentry#3716) fix(ember): Fix ember test flake (getsentry#3719) release: 6.7.2 ci: fix ember flaky test (getsentry#3718) misc: changelog for release 6.7.2 (getsentry#3717) fix(release-health): Prevent sending terminal status session updates (getsentry#3701) ref: Make beforeSend more strict (getsentry#3713) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:-
wrapEventFunctionbecause google cloud expects us to either await async code or return a promiseRef: https://cloud.google.com/functions/docs/concepts/nodejs-runtime#signal-termination
fixes: #3325