fix: Correctly limit Buffer requests #3736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
requested review from
a team,
ahmedetefy and
vladanpaunovic
and removed request for
a team
kamilogorek
force-pushed
the
fix-transport-buffer-limiting
branch
from
4c3b54b to
8d36cce
Compare
kamilogorek
requested review from
lobsterkatie,
AbhiPrasad,
HazAT,
iker-barriocanal and
rhcarvalho
and removed request for
vladanpaunovic
size-limit report
|
AbhiPrasad
requested changes
Jun 23, 2021
| * @returns The original promise. | ||
| */ | ||
| public add(task: PromiseLike<T>): PromiseLike<T> { | ||
| public add(taskProducer: PromiseLike<T> | TaskProducer<T>): PromiseLike<T> { | ||
| // NOTE: This is necessary to preserve backwards compatibility |
There was a problem hiding this comment.
Its implemented correctly in v7-dev branch already :)
AbhiPrasad
approved these changes
Jun 23, 2021
Co-authored-by: Abhijeet Prasad <[email protected]>
1999
added a commit
to 1999/sentry-javascript
that referenced
this pull request
Jun 25, 2021
…transport * upstream/master: (29 commits) ref: Always use lowercase files (getsentry#3742) feat: Make dedupe integration default for browser (getsentry#3730) ref(ember): Allow initing Ember without config entry (getsentry#3745) fix(serverless): wrapEventFunction does not await for async code (getsentry#3740) Metrics: Tag CLS elements (getsentry#3734) feat: Add Next.js 11 to supported peer dependencies list (getsentry#3711) test: Run integration tests for Next 10/11 and Webpack 4/5 matrix (getsentry#3741) fix: Correctly limit Buffer requests (getsentry#3736) Whoops. Remove pinned node version from package.json ref: Introduce test runner for node session health tests (getsentry#3728) fix: Prevent circular structure serialization in events (getsentry#3727) ref(node): Update Node manual tests and test for sessionCount (getsentry#3726) ref(ember): Update scenarios and remove a few to speed up tests (getsentry#3720) docs: Fix typos (getsentry#3716) fix(ember): Fix ember test flake (getsentry#3719) release: 6.7.2 ci: fix ember flaky test (getsentry#3718) misc: changelog for release 6.7.2 (getsentry#3717) fix(release-health): Prevent sending terminal status session updates (getsentry#3701) ref: Make beforeSend more strict (getsentry#3713) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd prefer to have
add(taskProducer: TaskProducer<T>): PromiseLike<T>signature, but the problem is that we might break custom transports that useBufferimplementation. Not even sure if there are any in the wild, so it might be worth playing it not safe and just go for a valid implementation already? fwiw the current implementation is basically broken, so I think it's better to implement it correctly and actually force people to update their custom transports if they have any.For reviewers: You can skip all
transport/file.tschanges. They only add() =>before eachnew Promise, but indentations make it look like a lot of changes (noting this as not everyone is usinghide whitespace changesin GitHub UI).Fixes #3725