feat: Add addToTransactions to Attachment #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extra parameter addToTransaction to attachment, which specifies if the SDK adds it to transactions or not. The default is false. Fixes GH-1185
philipphofmann
requested review from
bruno-garcia,
maciejwalkowiak and
marandaneto
as code owners
marandaneto
reviewed
Jan 21, 2021
| @@ -377,6 +377,21 @@ public void captureSession(final @NotNull Session session, final @Nullable Objec | |||
| return sentryId; | |||
| } | |||
|
|
|||
| private List<Attachment> filterForTransaction(List<Attachment> attachments) { | |||
There was a problem hiding this comment.
M: for nonprimitive types, lets always add final @NotNull or final @Nullable
a linter is on its way if we work together on https://github.com/getsentry/sentry-java/pull/1137/files#r548151954 :)
marandaneto
reviewed
Jan 21, 2021
marandaneto
approved these changes
Jan 21, 2021
philipphofmann
force-pushed
the
feat/add-to-transactions
branch
from
48c50de
to
5ac3bb9
Compare
Codecov Report
@@ Coverage Diff @@
## main #1191 +/- ##
============================================
+ Coverage 74.70% 74.76% +0.06%
- Complexity 1662 1669 +7
============================================
Files 174 174
Lines 5851 5866 +15
Branches 572 574 +2
============================================
+ Hits 4371 4386 +15
Misses 1216 1216
Partials 264 264
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Add extra parameter addToTransaction to attachment, which specifies if the SDK adds
it to transactions or not. The default is false.
💡 Motivation and Context
Fixes GH-1185
💚 How did you test it?
Unit tests.
📝 Checklist
🔮 Next steps