Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add addToTransactions to Attachment #1185

Closed
philipphofmann opened this issue Jan 19, 2021 · 3 comments · Fixed by #1191
Closed

Add addToTransactions to Attachment #1185

philipphofmann opened this issue Jan 19, 2021 · 3 comments · Fixed by #1191
Assignees
@philipphofmann
Labels
enhancement New feature or request performance Performance API issues
Milestone
4.0.0

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Jan 19, 2021 •
edited
Loading

The SentryClient currently adds attachments to transactions

sentry-java/sentry/src/main/java/io/sentry/SentryClient.java

Lines 359 to 360 in 2f8360a

final SentryEnvelope envelope =
buildEnvelope(sentryTransaction, getAttachmentsFromScope(scope));

This can add a huge overhead when putting large attachments to the scope. In order to avoid this, we can add addToTransactions to attachments and set the default to false. The Python SDK already has this flag.
@philipphofmann philipphofmann added this to the 4.0.0 milestone Jan 19, 2021
@philipphofmann philipphofmann added the enhancement New feature or request label Jan 19, 2021
@philipphofmann philipphofmann mentioned this issue Jan 19, 2021
Open
@philipphofmann philipphofmann changed the title Add addToTransaction to Attachments Add addToTransactions to Attachments Jan 19, 2021
@philipphofmann philipphofmann mentioned this issue Jan 19, 2021
Merged
@marandaneto marandaneto added the performance Performance API issues label Jan 19, 2021
@bruno-garcia
Copy link
Member

@philipphofmann we plan to release 4.0 next week, is this going to make into it?

@philipphofmann
Copy link
Member Author

@bruno-garcia I can take care of it.

@philipphofmann philipphofmann self-assigned this Jan 20, 2021
@bruno-garcia
Copy link
Member

Thanks @philipphofmann !

philipphofmann added a commit that referenced this issue Jan 21, 2021
@philipphofmann
feat: Add addToTransactions to Attachment
48c50de 
Add extra parameter addToTransaction to attachment, which specifies if the SDK adds the
it to transactions or not. The default is false.

Fixes GH-1185
@philipphofmann philipphofmann changed the title Add addToTransactions to Attachments Add addToTransactions to Attachment Jan 21, 2021
@philipphofmann philipphofmann mentioned this issue Jan 21, 2021
Merged
4 tasks
philipphofmann added a commit that referenced this issue Jan 21, 2021
@philipphofmann
feat: Add addToTransactions to Attachment
765144c 
Add extra parameter addToTransaction to attachment, which specifies if the SDK adds
it to transactions or not. The default is false.

Fixes GH-1185
philipphofmann added a commit that referenced this issue Jan 21, 2021
@philipphofmann
feat: Add addToTransactions to Attachment (#1191)
d0502db 
Add extra parameter addToTransaction to attachment, which specifies if the SDK adds
it to transactions or not. The default is false.

Fixes GH-1185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipphofmann philipphofmann

Labels
enhancement New feature or request performance Performance API issues
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

feat: Add addToTransactions to Attachment getsentry/sentry-java
3 participants
@bruno-garcia @philipphofmann @marandaneto