-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref: Bump AGP to 4.2.x and fix linter issues #1137
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-bin.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-bin.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ final class AndroidLogger implements ILogger { | |
|
||
private static final String tag = "Sentry"; | ||
|
||
@SuppressWarnings("AnnotateFormatMethod") | ||
@SuppressWarnings({"AnnotateFormatMethod", "LogConditional"}) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we check if logger is enabled by ourselves, we don't need to check the |
||
@Override | ||
public void log(SentryLevel level, String message, Object... args) { | ||
Log.println(toLogcatLevel(level), tag, String.format(message, args)); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ public abstract class EnvelopeFileObserverIntegration implements Integration, Cl | |
private @Nullable EnvelopeFileObserver observer; | ||
private @Nullable ILogger logger; | ||
|
||
@SuppressWarnings("SyntheticAccessor") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there are a bunch of SyntheticAccessor errors for private static final classes, not sure if they make sense or are false positive, I don't see how could it be problematic |
||
public static @NotNull EnvelopeFileObserverIntegration getOutboxFileObserver() { | ||
return new OutboxEnvelopeFileObserverIntegration(); | ||
} | ||
|
@@ -67,6 +68,7 @@ public void close() { | |
@TestOnly | ||
abstract @Nullable String getPath(final @NotNull SentryOptions options); | ||
|
||
@SuppressWarnings("SyntheticAccessor") | ||
private static final class OutboxEnvelopeFileObserverIntegration | ||
extends EnvelopeFileObserverIntegration { | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ import io.sentry.SentryOptions | |
/** | ||
* Verifies is [SentryEnvelope] contains first event matching a predicate. | ||
*/ | ||
inline fun checkEvent(noinline predicate: (SentryEvent) -> Unit): SentryEnvelope { | ||
fun checkEvent(predicate: (SentryEvent) -> Unit): SentryEnvelope { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no reason to be inlined, first because has no effect for this usecase, 2nd because its a testing class |
||
val options = SentryOptions().apply { | ||
setSerializer(GsonSerializer(NoOpLogger.getInstance(), envelopeReader)) | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -335,6 +335,7 @@ private int decrement(int index) { | |
* | ||
* @return an iterator over this queue's elements | ||
*/ | ||
@SuppressWarnings("SyntheticAccessor") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I prefer to not touch this class that is borrowed from Apache package |
||
@Override | ||
public Iterator<E> iterator() { | ||
return new Iterator<E>() { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philipphofmann help me to fix those
so no manoelly linter :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basic all public getters and setters would need either @NotNull or @nullable, overwhelming hehe, I'd guess around 700
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added this disable rule to make CI happier and focus on the other lint issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.