Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to declarative labels #6772

Merged
merged 5 commits into from
Apr 28, 2023
Merged

Switch to declarative labels #6772

merged 5 commits into from
Apr 28, 2023

Conversation

chadwhitacre
Copy link
Member

@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 8:51pm

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2023

🏷 The following changes will be made to the repository labels

Validating provided labels
Fetching labels from GitHub
Labels are already up to date

@chadwhitacre
Copy link
Member Author

Quick seatbelt:

$ cat .github/labels.yml | grep '\- name' | wc -l
      80
$

Also seeing 80 in the UI:

Screenshot 2023-04-28 at 4 26 40 PM

Ftr I fetched with (note per_page):

curl 'https://api.github.com/repos/getsentry/sentry-docs/labels?per_page=200' > labels.json

And I transmogrified with:

#!/usr/bin/env python3
import json, yaml

labels_in = json.load(open(f'labels.json'))
labels_out = []
for label in labels_in:
    labels_out.append({
        'name': label['name'],
        'aliases': [],
        'color': label['color'],
        'description': label['description'],
    })

fp = open('.github/labels.yml', 'w+')
yaml.dump(labels_out, fp, sort_keys=False)

I don't like the look of that comment, though ... 🤔

@chadwhitacre
Copy link
Member Author

Comment looking better, not sure if due to 8f577fb (likely?) or 6db7cf4. Testing with 8637f5c ...

@chadwhitacre
Copy link
Member Author

I think we're good. 👍

@chadwhitacre chadwhitacre requested a review from a team April 28, 2023 20:33
Copy link
Member

@hubertdeng123 hubertdeng123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, sync-labels.yml is the same as we use in sentry and the dry run won't change current labels

@chadwhitacre chadwhitacre requested a review from a team April 28, 2023 20:42
@chadwhitacre chadwhitacre merged commit a537477 into master Apr 28, 2023
@chadwhitacre chadwhitacre deleted the cwlw/declarative-labels branch April 28, 2023 20:52
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants