Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Declarative github labels #36833

Merged

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Jul 19, 2022

Makes labels declarative

Slightly afraid this is going to delete all labels.

Edit: Turned off pruning for now so we can be sure it won't delete everything

Comment on lines +8 to +9
jobs:
build:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's set the explicit permissions we want here just to be ~slightly safer -- https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/feat-ci-declarative-github-labels branch from d811997 to 1a7f240 Compare July 20, 2022 20:37
@evanpurkhiser evanpurkhiser merged commit 56a8862 into master Jul 20, 2022
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/feat-ci-declarative-github-labels branch July 20, 2022 22:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants