Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feedback): prefill user info in form #4630

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

armcknight
Copy link
Member

also use better autocapitalization settings for the name/email fields

#skip-changelog

Copy link

github-actions bot commented Dec 12, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 880be53

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.897%. Comparing base (fce741e) to head (880be53).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...grations/UserFeedback/SentryUserFeedbackForm.swift 0.000% 8 Missing ⚠️
Sources/Sentry/SentryUserAccess.m 0.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4630       +/-   ##
=============================================
+ Coverage   90.882%   90.897%   +0.014%     
=============================================
  Files          617       618        +1     
  Lines        71032     71061       +29     
  Branches     25332     25948      +616     
=============================================
+ Hits         64556     64593       +37     
+ Misses        6384      6372       -12     
- Partials        92        96        +4     
Files with missing lines Coverage Δ
Sources/Sentry/SentryUserAccess.m 0.000% <0.000%> (ø)
...grations/UserFeedback/SentryUserFeedbackForm.swift 0.000% <0.000%> (ø)

... and 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce741e...880be53. Read the comment docs.

Copy link

github-actions bot commented Dec 12, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.52 ms 1252.90 ms 19.38 ms
Size 22.31 KiB 756.67 KiB 734.37 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
dd0557f 1251.82 ms 1256.76 ms 4.94 ms
6ec751f 1230.57 ms 1252.12 ms 21.55 ms
06548c0 1262.80 ms 1275.00 ms 12.20 ms
742d4b6 1191.02 ms 1207.08 ms 16.06 ms
ecd9ecd 1241.28 ms 1260.35 ms 19.07 ms
b8ac050 1222.52 ms 1249.87 ms 27.35 ms
f1ed6f8 1210.94 ms 1230.78 ms 19.84 ms
f0283e8 1245.92 ms 1262.82 ms 16.90 ms
e4c9841 1222.41 ms 1237.10 ms 14.69 ms
90d17d3 1261.18 ms 1278.18 ms 17.00 ms

App size

Revision Plain With Sentry Diff
dd0557f 22.85 KiB 411.75 KiB 388.91 KiB
6ec751f 21.58 KiB 625.83 KiB 604.24 KiB
06548c0 20.76 KiB 427.36 KiB 406.59 KiB
742d4b6 21.58 KiB 546.20 KiB 524.62 KiB
ecd9ecd 20.76 KiB 420.23 KiB 399.47 KiB
b8ac050 21.90 KiB 709.06 KiB 687.16 KiB
f1ed6f8 21.58 KiB 683.51 KiB 661.93 KiB
f0283e8 20.76 KiB 393.37 KiB 372.61 KiB
e4c9841 21.58 KiB 706.46 KiB 684.88 KiB
90d17d3 20.76 KiB 432.17 KiB 411.41 KiB

Previous results on branch: armcknight/feat(feedback)/ui-form-use-user

Startup times

Revision Plain With Sentry Diff
8a02c54 1228.11 ms 1262.32 ms 34.21 ms
32eb9b6 1221.91 ms 1244.48 ms 22.57 ms
8f62dff 1240.42 ms 1248.70 ms 8.28 ms
a029ce3 1239.27 ms 1254.90 ms 15.63 ms

App size

Revision Plain With Sentry Diff
8a02c54 22.31 KiB 756.74 KiB 734.44 KiB
32eb9b6 22.31 KiB 756.74 KiB 734.44 KiB
8f62dff 22.31 KiB 756.74 KiB 734.43 KiB
a029ce3 22.31 KiB 756.74 KiB 734.43 KiB

@armcknight
Copy link
Member Author

armcknight commented Dec 13, 2024

Can anyone help me understand why this build error is happening in the static pod lint jobs?

    /Users/runner/Library/Developer/Xcode/DerivedData/App-bjyzyimqwewksvgrwopofoofeyje/Build/Intermediates.noindex/Pods.build/Release/Sentry.build/DerivedSources/Sentry-Swift.h:1152:9: fatal error: module '_SentryPrivate' not found
    @import _SentryPrivate;
     ~~~~~~~^~~~~~~~~~~~~~

@philipphofmann
Copy link
Member

Can anyone help me understand why this build error is happening in the static pod lint jobs?

    /Users/runner/Library/Developer/Xcode/DerivedData/App-bjyzyimqwewksvgrwopofoofeyje/Build/Intermediates.noindex/Pods.build/Release/Sentry.build/DerivedSources/Sentry-Swift.h:1152:9: fatal error: module '_SentryPrivate' not found
    @import _SentryPrivate;
     ~~~~~~~^~~~~~~~~~~~~~

That's due to our weird internal Swift setup. You can't add these headers to SentryPrivate.h because they both depend on public classes:

#import "SentrySDK+Private.h"
#import "SentryScope+Private.h"

I usually solve this by creating a protocol or class in Swift and then implementing a wrapper class in ObjC. For example for the metrics, I wrote this class in Swift https://github.com/getsentry/sentry-cocoa/blob/8.38.0/Sources/Swift/Metrics/SentryMetricsClient.swift and then StatsdClient in ObjC https://github.com/getsentry/sentry-cocoa/blob/8.38.0/Sources/Sentry/SentryStatsdClient.m.

I know it's weird, and it gives me headaches quite often.

@armcknight armcknight merged commit e8f2cfd into main Dec 13, 2024
69 of 70 checks passed
@armcknight armcknight deleted the armcknight/feat(feedback)/ui-form-use-user branch December 13, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants