-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feedback): prefill user info in form #4630
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4630 +/- ##
=============================================
+ Coverage 90.882% 90.897% +0.014%
=============================================
Files 617 618 +1
Lines 71032 71061 +29
Branches 25332 25948 +616
=============================================
+ Hits 64556 64593 +37
+ Misses 6384 6372 -12
- Partials 92 96 +4
... and 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
dd0557f | 1251.82 ms | 1256.76 ms | 4.94 ms |
6ec751f | 1230.57 ms | 1252.12 ms | 21.55 ms |
06548c0 | 1262.80 ms | 1275.00 ms | 12.20 ms |
742d4b6 | 1191.02 ms | 1207.08 ms | 16.06 ms |
ecd9ecd | 1241.28 ms | 1260.35 ms | 19.07 ms |
b8ac050 | 1222.52 ms | 1249.87 ms | 27.35 ms |
f1ed6f8 | 1210.94 ms | 1230.78 ms | 19.84 ms |
f0283e8 | 1245.92 ms | 1262.82 ms | 16.90 ms |
e4c9841 | 1222.41 ms | 1237.10 ms | 14.69 ms |
90d17d3 | 1261.18 ms | 1278.18 ms | 17.00 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
dd0557f | 22.85 KiB | 411.75 KiB | 388.91 KiB |
6ec751f | 21.58 KiB | 625.83 KiB | 604.24 KiB |
06548c0 | 20.76 KiB | 427.36 KiB | 406.59 KiB |
742d4b6 | 21.58 KiB | 546.20 KiB | 524.62 KiB |
ecd9ecd | 20.76 KiB | 420.23 KiB | 399.47 KiB |
b8ac050 | 21.90 KiB | 709.06 KiB | 687.16 KiB |
f1ed6f8 | 21.58 KiB | 683.51 KiB | 661.93 KiB |
f0283e8 | 20.76 KiB | 393.37 KiB | 372.61 KiB |
e4c9841 | 21.58 KiB | 706.46 KiB | 684.88 KiB |
90d17d3 | 20.76 KiB | 432.17 KiB | 411.41 KiB |
Previous results on branch: armcknight/feat(feedback)/ui-form-use-user
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8a02c54 | 1228.11 ms | 1262.32 ms | 34.21 ms |
32eb9b6 | 1221.91 ms | 1244.48 ms | 22.57 ms |
8f62dff | 1240.42 ms | 1248.70 ms | 8.28 ms |
a029ce3 | 1239.27 ms | 1254.90 ms | 15.63 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8a02c54 | 22.31 KiB | 756.74 KiB | 734.44 KiB |
32eb9b6 | 22.31 KiB | 756.74 KiB | 734.44 KiB |
8f62dff | 22.31 KiB | 756.74 KiB | 734.43 KiB |
a029ce3 | 22.31 KiB | 756.74 KiB | 734.43 KiB |
Can anyone help me understand why this build error is happening in the static pod lint jobs?
|
Samples/iOS-Swift/iOS-Swift.xcodeproj/xcshareddata/xcschemes/iOS-Swift.xcscheme
Outdated
Show resolved
Hide resolved
…OS-Swift.xcscheme
That's due to our weird internal Swift setup. You can't add these headers to
I usually solve this by creating a protocol or class in Swift and then implementing a wrapper class in ObjC. For example for the metrics, I wrote this class in Swift https://github.com/getsentry/sentry-cocoa/blob/8.38.0/Sources/Swift/Metrics/SentryMetricsClient.swift and then StatsdClient in ObjC https://github.com/getsentry/sentry-cocoa/blob/8.38.0/Sources/Sentry/SentryStatsdClient.m. I know it's weird, and it gives me headaches quite often. |
also use better autocapitalization settings for the name/email fields
#skip-changelog