Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(iOS-Swift): reorganize SDK configuration #4628

Merged
merged 5 commits into from
Dec 14, 2024

Conversation

armcknight
Copy link
Member

  • remove the need for most of the swiftlint toggles we had for type/function length and cyclomatic complexity
  • remove a few things that just set the option to the default value
  • fix some cases where the same setting was set twice
  • add a launch argument to easily disable everything
  • organize things with // MARK::
image

Food for thought: this points towards a potential enhancement to be able to configure the SDK using a plist. Wonder if customers have ever asked for it? I'm just looking at the long list of options in code and the scheme and thinking we could move that checking logic into the SDK itself.

#skip-changelog

Copy link

github-actions bot commented Dec 12, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1239.43 ms 1262.20 ms 22.78 ms
Size 22.31 KiB 756.67 KiB 734.37 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
dd0557f 1242.04 ms 1250.86 ms 8.82 ms
6ec751f 1237.88 ms 1258.47 ms 20.59 ms
5e65d2b 1216.08 ms 1236.08 ms 20.00 ms
b35ccd0 1238.67 ms 1260.35 ms 21.67 ms
06548c0 1225.58 ms 1244.70 ms 19.12 ms
4259afd 1222.12 ms 1249.74 ms 27.62 ms
ecd9ecd 1215.77 ms 1238.70 ms 22.93 ms
853d797 1221.40 ms 1233.98 ms 12.58 ms
279351b 1229.00 ms 1233.63 ms 4.63 ms
313b1d9 1240.18 ms 1258.44 ms 18.26 ms

App size

Revision Plain With Sentry Diff
dd0557f 22.85 KiB 411.75 KiB 388.90 KiB
6ec751f 21.58 KiB 625.82 KiB 604.24 KiB
5e65d2b 21.58 KiB 616.67 KiB 595.09 KiB
b35ccd0 21.58 KiB 573.13 KiB 551.55 KiB
06548c0 20.76 KiB 427.35 KiB 406.59 KiB
4259afd 20.76 KiB 419.70 KiB 398.94 KiB
ecd9ecd 20.76 KiB 420.23 KiB 399.47 KiB
853d797 21.58 KiB 630.35 KiB 608.77 KiB
279351b 21.58 KiB 706.53 KiB 684.95 KiB
313b1d9 22.85 KiB 414.11 KiB 391.26 KiB

Previous results on branch: armcknight/ref/ios-swift-app-delegate

Startup times

Revision Plain With Sentry Diff
93a977d 1241.15 ms 1255.16 ms 14.00 ms
0ab7d5f 1231.87 ms 1252.50 ms 20.63 ms

App size

Revision Plain With Sentry Diff
93a977d 22.31 KiB 756.42 KiB 734.11 KiB
0ab7d5f 22.31 KiB 756.42 KiB 734.11 KiB

@brustolin
Copy link
Contributor

this points towards a potential enhancement to be able to configure the SDK using a plist. Wonder if customers have ever asked for it?

No, I dont think so.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please merge this quickly to avoid merge conflicts.

@armcknight armcknight merged commit 4f2aced into main Dec 14, 2024
54 checks passed
@armcknight armcknight deleted the armcknight/ref/ios-swift-app-delegate branch December 14, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants