fix: Fallback to xcodebuild vars for faulty Info.plist files #1310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sort of an edge-case, as XCode is not producing an
Info.plist
fileby default anymore. However, it still does so for some templates.
For example iOS Storyboard template will produce a partial
Info.plist
file,with a content only related to the Storyboard itself, but not the project as a whole. eg.
This causes a false-positive in this branch, as
INFOPLIST_FILE
is present, yet it containsno data required by the CLI to correctly produce a
InfoPlist
struct.In the case like that, we try to fallback to variables produced by
xcodebuild
binary,and read them directly, just like we do in
from_xcode_env
method.Fixes #1301