-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using upload-dif
results in Serde("missing field CFBundleName
")
#1301
Comments
Also, I have found similar but resolved issues: #895 I want to use sentry plugin fastlane for uploading debug symbols via Using App Store Connect which seems more interesting for me because there is no need to wait for build processing. But I can't run the solution out of the box. Is there some workaround to use it? |
Seems that sentry_upload_dsym fastlane action also don't work in the same environment, I see the same error 😞 |
Regarding link in Sentry https://betterprogramming.pub/info-plist-is-missing-in-xcode-13-heres-how-to-get-it-back-1a7abf3e2514 I have Info.plist in my project |
Hey @artur-zaremba
This sill feels like a workaround rather then a real solution but at least it unblocked me. |
Thanks @fzymek, seems like it doesn't work without a workaround, that is why I summarised the issue from other closed issues. Seems like Sentry devs don't see it as a problem |
@brustolin is working on iOS, ideas? |
Im not familiar with sentry-cli. I would need to investigate this a little bit. @artur-zaremba Any minimum repro would be very helpful |
Any new Xcode project should suffice as a repro, as the issue will be there by default. As to potential workarounds or fixes, it would be a matter of finding and parsing the right data from the right file, which I'm assuming would be the project file, but not entirely sure as I haven't delved too deep into this recent(ish) change. By the looks of things, Apple is trying to get rid of Info.plist entirely, which will undoubtedly break a lot of 3rd party functionality, automation etc. |
Hi, I have the same problem in a new project created with Xcode 13.3.1, for Min target iOS 14 What fzymek suggested did not work for me, but this did <key>CFBundleIdentifier</key>
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
<key>CFBundleName</key>
<string>$(PRODUCT_NAME)</string>
<key>CFBundleVersion</key>
<string>$(CURRENT_PROJECT_VERSION)</string>
<key>CFBundleShortVersionString</key>
<string>$(MARKETING_VERSION)</string> Include |
Sounds like the new xcode doesn't create the info.plist file containing the information we need (e.g Is the bundle name anywhere to be found? We can ask @kamilogorek for help in changing |
Yes, thats true.
Yes. PROJECT_NAME.xcodeproj/project.pbxproj But this line appears once for each environment (debug, release, ...). I dont see why someone would use different values but this is something to keep in mind. @kamilogorek can you help us out to update |
It's important to fall back to the old |
I think the plist should be the default tbh, I believe plist have priority over the project value. |
Well, funny enough I cannot repro this issue with a fresh project on the same xcode version ¯_(ツ)_/¯
We already fall back to those values in some cases, but it's unclear what code path is taken in the OPs case. Would be great if I could get a repro. |
I also could not repro this. |
I have just created new project, added SPM library and added initialization code in AppDelegate.swift. Then I uploaded it to TestFlight, downloaded dSYM and tried upload it via |
Thanks for this. I got the same problematic behaviour. Can you add @kamilogorek too in you sample project please? BTW, which type of new project do you use in your xCode? I created a new iOS SwiftUI from scratch and did not got the same outcome. |
Sure, I will add him. |
Got the repro, found the issue, working on the fix |
@artur-zaremba should be fixed in |
Hi @kamilogorek , I updated to |
@danielrobleM can you provide a concrete repro for this? I verified using @artur-zaremba repro, which had the same bug, and it's fixed now for his case. |
@danielrobleM your usecase should be fixed in |
Just in case, faced this issue with The workaround was to force it use Info.plist from .xcarchive itself like below:
|
Environment
macOS 12.4
Xcode 13.4.1, iOS app for min iOS 13
sentry-cli 2.5.0 installed via homebrew
Steps to reproduce
sentry-cli upload-dif -o ORG -p PROJECT --wait --log-level=debug ./AppName.app.dSYM.zip
Expected Result
Debug information files uploaded to Sentry.
Actual Result
error: Could not parse Info.plist file caused by: Serde("missing field
CFBundleName")
The text was updated successfully, but these errors were encountered: