-
-
Notifications
You must be signed in to change notification settings - Fork 120
Conversation
I removed commits related to #195 |
Looks like 5 out of 10 open pull requests in this repository are directly related to .NET Core or .NET Standard compatibility. Some of them are open for over a year. I'm worried that this PR will share their fate. What do you guys (that is, maintainers of this repo) think about .NET Core and .NET Standard? Are there any insurmountable techincal difficulties we don't see? |
@trurl123 @asbjornu I just pulled this PR and tested it out on one of my .Net Core Apps 2.0 and it works as expected. I think the Package task in the |
@michaeljbaird: That sounds great! I'll merge this and then we can polish the package metadata in a separate pull request. Are you up for the task? 😃 |
@asbjornu absolutely. At some point, when do you think net35 can be dropped? It would simplfy the build. |
@michaeljbaird: Excellent. As the .NET 3.5 support was added rather recently, I don't think we're ready to remove it just yet. |
Also make some properties public to use from custom log aggregator
UPDATE: moved properties fix to another PR