Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Add .net standard support #197

Merged
merged 7 commits into from
Mar 2, 2018
Merged

Conversation

trurl123
Copy link
Contributor

@trurl123 trurl123 commented Nov 22, 2017

Also make some properties public to use from custom log aggregator
UPDATE: moved properties fix to another PR

@asbjornu
Copy link
Contributor

This PR tackles a bit more than what was discussed in #195. As far as I can see, only 9e026a5 seems related to that issue. Would it be possible to have that commit (and related changes) in its own PR, so we can discuss .NET Standard support separately?

@trurl123
Copy link
Contributor Author

I removed commits related to #195
So this PR contains only .net standard support

@beevee
Copy link

beevee commented Nov 27, 2017

Looks like 5 out of 10 open pull requests in this repository are directly related to .NET Core or .NET Standard compatibility. Some of them are open for over a year. I'm worried that this PR will share their fate.

What do you guys (that is, maintainers of this repo) think about .NET Core and .NET Standard? Are there any insurmountable techincal difficulties we don't see?

@MikeBairdRocks
Copy link
Contributor

@trurl123 @asbjornu I just pulled this PR and tested it out on one of my .Net Core Apps 2.0 and it works as expected. I think the Package task in the build.cake script needs a little work as it outputs a Nuget package but does not include icon, description...etc. as before but other than that, it should be ready for nuget.org 👍

@asbjornu
Copy link
Contributor

asbjornu commented Mar 2, 2018

@michaeljbaird: That sounds great! I'll merge this and then we can polish the package metadata in a separate pull request. Are you up for the task? 😃

@MikeBairdRocks
Copy link
Contributor

MikeBairdRocks commented Mar 3, 2018

@asbjornu absolutely. At some point, when do you think net35 can be dropped? It would simplfy the build.

@asbjornu
Copy link
Contributor

asbjornu commented Mar 3, 2018

@michaeljbaird: Excellent. As the .NET 3.5 support was added rather recently, I don't think we're ready to remove it just yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants