Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Added Seperate Dotnet Core Project #161

Closed

Conversation

wakawaka54
Copy link

@wakawaka54 wakawaka54 commented Sep 23, 2016

Any tests that used the TestServer had to be commented out due to no compatibility with core. We can rewrite these tests using Microsoft.AspNetCore.TestServer.


This change is Reviewable

Copy link
Contributor

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! But I wonder; can't all the copied files be linked instead, so we don't end up with duplicates? If required, we can do #if (netcore) in places where .NET Core needs a different code path from the other target frameworks.

@asbjornu
Copy link
Contributor

I also need some kind of advice on how to get the project built on TeamCity.

@reflectiondm
Copy link

@wakawaka54 I missed that you started the work on creating a separate dotnet Core project so I also have created one here: #163 . It is already addressing @asbjornu comment regarding files to be linked instead of just coppied. Do you think we can cooperate on it? What's the best way to contact you?

@wakawaka54
Copy link
Author

@reflectiondm Yes we can! Do you use something I can PM you on and we can talk about the changes and work together?

@reflectiondm
Copy link

@wakawaka54 I've sent you an email to an email address I found on your profile page.

@asbjornu
Copy link
Contributor

asbjornu commented Mar 3, 2018

I hope #197 gives us the .NET Core / Standard support we need, so I'm closing this. Please rebase on HEAD of develop and reopen if there's something you feel is missing or has room for improvement. Thanks!

@asbjornu asbjornu closed this Mar 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants