Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Feature/add dotnet core project #163

Closed
wants to merge 8 commits into from
Closed

Feature/add dotnet core project #163

wants to merge 8 commits into from

Conversation

reflectiondm
Copy link

@reflectiondm reflectiondm commented Sep 27, 2016

Hi!
Please look into this port of SharpRaven to dotnet Core. A new project has been created, most of the files are directly referenced from a regular .net project. The ones that are incopatible have been replaced with dotnet core implementation.
A nuget package is created upon build.
I've tested the package with our dotnet core project and it works. Known issues: stacktrace is not attached to a request and thus is not in the exception details in Sentry.
Your feedback and suggestions are welcome.


This change is Reviewable

@asbjornu
Copy link
Contributor

@reflectiondm: Thanks! But can you please coordinate with @wakawaka54 who just created #161?

@reflectiondm
Copy link
Author

@asbjornu oh, sure! I somehow missed that the work has been started on your side =)

@asbjornu asbjornu mentioned this pull request Nov 1, 2017
@asbjornu
Copy link
Contributor

asbjornu commented Mar 3, 2018

I hope #197 gives us the .NET Core / Standard support we need, so I'm closing this. Please rebase on HEAD of develop and reopen if there's something you feel is missing or has room for improvement. Thanks!

@asbjornu asbjornu closed this Mar 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants