This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 224
Specification: Better scrubbing of sensitive data #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Dec 1, 2022
cleptric
reviewed
Dec 5, 2022
cleptric
reviewed
Dec 5, 2022
gggritso
reviewed
Dec 6, 2022
gggritso
reviewed
Dec 6, 2022
gggritso
reviewed
Dec 6, 2022
Co-authored-by: Michi Hoffmann <[email protected]>
marandaneto
reviewed
Dec 14, 2022
cleptric
reviewed
Dec 14, 2022
cleptric
reviewed
Dec 14, 2022
cleptric
reviewed
Dec 14, 2022
cleptric
reviewed
Dec 14, 2022
cleptric
reviewed
Dec 14, 2022
src/docs/sdk/data-handling.mdx
Outdated
- The username logged in the device is not included. This is often a person's name. | ||
- The machine name is not included, for example `Bruno's laptop` | ||
- SDKs don't set `{{auto}}` as `user.ip`. This instructs the server to keep the connection's IP address.\* | ||
- Specifically about IP address, it's important to note that it's standard to log IP address of incoming connecting in services on the Internet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has some GDPR impact. While I agree that having an IP address attached to an event can be useful, we might reword this a bit.
cleptric
reviewed
Dec 14, 2022
Co-authored-by: Manoel Aranda Neto <[email protected]>
…related to Sentry.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RFC-0038 we decided to implement better data scrubbing of sensitive data.
This is now the specification that all SDKs and Relay can implement to have better data scrubbing.