-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize sensitive data from URLs sent to Sentry #6389
Comments
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
@smeubank my team recently noticed that our performance traces have span descriptions with sensitive data because of this integration: new Sentry.Integrations.Http({ tracing: true }), Example span description:
Ideally those sensitive values would be auto-scrubbed server side It looks to me like this is exactly what this issue is about? I'd be happy to help work on this, but I see there is no |
@aldenquimby please go ahead an open a PR, they are always welcome :) |
Problem Statement
When we do HTTP requests to third party services we create a breadcrumb with the URL and also create a span that has the URL as a description (and also breadcrumbs including this URL are created.)
Solution Brainstorm
We created RFC-0038 to decide how to improve the current situation and creating a spec here: getsentry/develop#773
Make sure that all integrations that record outgoing or incoming HTTP request structure the data like described in the spec linked above.
original issue:
getsentry/sentry-python#1742
The text was updated successfully, but these errors were encountered: