Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize sensitive data from URLs sent to Sentry #6389

Closed
smeubank opened this issue Dec 2, 2022 · 5 comments
Closed

Sanitize sensitive data from URLs sent to Sentry #6389

smeubank opened this issue Dec 2, 2022 · 5 comments
Labels
Package: node Issues related to the Sentry Node SDK Type: Improvement

Comments

@smeubank
Copy link
Member

smeubank commented Dec 2, 2022

Problem Statement

When we do HTTP requests to third party services we create a breadcrumb with the URL and also create a span that has the URL as a description (and also breadcrumbs including this URL are created.)

Solution Brainstorm

We created RFC-0038 to decide how to improve the current situation and creating a spec here: getsentry/develop#773

Make sure that all integrations that record outgoing or incoming HTTP request structure the data like described in the spec linked above.

original issue:

getsentry/sentry-python#1742

@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@aldenquimby
Copy link
Contributor

aldenquimby commented Feb 15, 2023

@smeubank my team recently noticed that our performance traces have span descriptions with sensitive data because of this integration:

new Sentry.Integrations.Http({ tracing: true }),

Example span description:

GET https://api.mywebsite.com/renew_access_token?key=SENSITIVE&token=SENSITIVE

Ideally those sensitive values would be auto-scrubbed server side

It looks to me like this is exactly what this issue is about? I'd be happy to help work on this, but I see there is no Help Wanted label. Would you be open to a PR on this, or do you already have plans to implement? I think the changes would center around http.ts

@HazAT
Copy link
Member

HazAT commented Feb 16, 2023

@aldenquimby please go ahead an open a PR, they are always welcome :)

@aldenquimby
Copy link
Contributor

@HazAT here you go! #7206

@cleptric
Copy link
Member

#7667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: node Issues related to the Sentry Node SDK Type: Improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants