Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize sensitive data from URLs sent to Sentry #2078

Closed
Tracked by #70
mattjohnsonpint opened this issue Dec 6, 2022 · 1 comment · Fixed by #2365
Closed
Tracked by #70

Sanitize sensitive data from URLs sent to Sentry #2078

mattjohnsonpint opened this issue Dec 6, 2022 · 1 comment · Fixed by #2365
Assignees
@jamescrosswell
Labels
Feature New feature or request

Comments

@mattjohnsonpint
Copy link
Contributor

mattjohnsonpint commented Dec 6, 2022 •
edited by jamescrosswell
Loading

Per getsentry/team-webplatform-meta#2 and getsentry/team-mobile#70, ensure all captured URLs are sanitized according to the new spec in getsentry/develop#773 (when it is ready)

Description

When we make HTTP requests to third party services we create a breadcrumb with the URL and also create a span that has the URL as a description (and also breadcrumbs including this URL are created.)

Make sure that all integrations that record outgoing or incoming HTTP request structure the data like described in the spec linked above.

References
This was referenced Dec 6, 2022
Closed
Closed
@mattjohnsonpint mattjohnsonpint added Feature New feature or request Impact: Medium labels Dec 6, 2022
@mattjohnsonpint mattjohnsonpint moved this to Needs Discussion in Mobile & Cross Platform SDK Dec 6, 2022
@mattjohnsonpint mattjohnsonpint moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Dec 6, 2022
@mattjohnsonpint mattjohnsonpint mentioned this issue Dec 6, 2022
Open
@mattjohnsonpint mattjohnsonpint self-assigned this Apr 24, 2023
@mattjohnsonpint mattjohnsonpint removed their assignment May 10, 2023
@jamescrosswell jamescrosswell self-assigned this May 10, 2023
@mattjohnsonpint
Copy link
Contributor Author

Rendered spec: https://develop.sentry.dev/sdk/data-handling/

@mattjohnsonpint mattjohnsonpint moved this from Backlog to In Progress in Mobile & Cross Platform SDK May 10, 2023
@jamescrosswell jamescrosswell mentioned this issue May 12, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mobile & Cross Platform SDK May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamescrosswell jamescrosswell

Labels
Feature New feature or request
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove authority from URLs sent to Sentry getsentry/sentry-dotnet
2 participants
@jamescrosswell @mattjohnsonpint