Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Query pages to React: cleanup #4512

Conversation

kravets-levko
Copy link
Collaborator

@kravets-levko kravets-levko commented Dec 30, 2019

What type of PR is this? (check all applicable)

  • Other

Description

  • Remove unused Angular component;
  • Remove unused directives, filters, etc.
  • Remove unused dependencies.
  • Tests

Related Tickets & Documents

#4429

@kravets-levko kravets-levko added Frontend Frontend: React Frontend codebase migration to React labels Dec 30, 2019
@kravets-levko kravets-levko self-assigned this Dec 30, 2019
@kravets-levko kravets-levko force-pushed the migrate-query-source-view-to-react--cleanup branch from 20c0027 to 0e9d1a6 Compare December 30, 2019 16:37
@kravets-levko kravets-levko marked this pull request as ready for review December 30, 2019 16:38
@kravets-levko kravets-levko force-pushed the migrate-query-source-view-to-react--cleanup branch from 0e9d1a6 to deaa1e2 Compare December 30, 2019 17:09
@kravets-levko kravets-levko changed the title Migrate Query pages to React: cleanup (WIP) Migrate Query pages to React: cleanup Dec 30, 2019
@kravets-levko kravets-levko force-pushed the migrate-query-source-view-to-react--cleanup branch from 466dab4 to 76461a8 Compare December 31, 2019 10:57
@kravets-levko kravets-levko force-pushed the migrate-query-source-view-to-react--cleanup branch from 9342276 to 197e3e2 Compare December 31, 2019 11:36
@kravets-levko kravets-levko force-pushed the migrate-query-source-view-to-react--cleanup branch from 197e3e2 to 2fdd34e Compare December 31, 2019 11:37
@kravets-levko kravets-levko changed the title (WIP) Migrate Query pages to React: cleanup Migrate Query pages to React: cleanup Dec 31, 2019
@gabrieldutra gabrieldutra mentioned this pull request Dec 31, 2019
27 tasks
Copy link
Member

@gabrieldutra gabrieldutra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in code look good to me, so good to see so much going away 🚀. Most of all now is testing.

},
route.resolve
);
route.authenticated = route.authenticated !== false; // could be set to `false` do disable auth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gabrieldutra gabrieldutra force-pushed the migrate-query-source-view-to-react--cleanup branch from 92cd95b to 418ea7c Compare December 31, 2019 20:27
@kravets-levko kravets-levko force-pushed the migrate-query-source-view-to-react branch 2 times, most recently from 2d2c997 to 2934e53 Compare January 2, 2020 16:25
@kravets-levko kravets-levko merged commit 9729b72 into migrate-query-source-view-to-react Jan 6, 2020
@kravets-levko kravets-levko deleted the migrate-query-source-view-to-react--cleanup branch January 6, 2020 17:47
kravets-levko added a commit that referenced this pull request Jan 6, 2020
* Migrate Query Source View page to React: skeleton

* Sync QueryView and QuerySource (#4430)

* Migrate schema browser to react (#4432)

* Restyle code with Prettier

* Migrate Query page to React: Save changes (#4452)

* Migrate query source to React: Set of updates (#4457)

* Migrate Query page to React: Visualization Tabs (#4453)

Co-Authored-By: Levko Kravets <[email protected]>

* Migrate Query Source page to React: Visualizations area (#4463)

* Migrate Query page to React: Delete visualization button (#4461)

* Migrate Query Source page to React: Visualization actions (#4467)

* Migrate Query pages to React: Execute query hook (#4470)

* Migrate Query Source page to React: Editor area (#4468)

* Migrate Query Source page to React: metadata, schedule and description blocks (#4476)

* Migrate Query page to React: Cancel query execution (#4496)

* Migrate Query Source page to React: refine code (#4499)

* Migrate Query Source page to React: alerts (#4504)

* Migrate Query Source page to React: unsaved changes alert (#4505)

* Migrate Query Source to React: resizable areas (v2) (#4503)

* Migrate Query page to React: Query View (#4455)

Co-authored-by: Levko Kravets <[email protected]>

* Switch React and Angular versions of pages (until Angular version removed)

* Migrate Query pages to React: fix permissions (#4506)

* Migrate Query Source page to React: don't reload when saving new query (#4507)

* Migrate Query pages to React: fix tests (#4509)

* Use skipParametersDirtyFlag in executeQuery

* Fix: cannot fork query from Query View page

* Optimize query editor: handle query text changes faster

* Revert "Optimize query editor: handle query text changes faster"

This reverts commit 2934e53.

* Reduce debounced time to 100

* Migrate Query pages to React: cleanup (#4512)

* Migrate Query pages to React: cleanup

* Further cleanup

* Remove unused dependencies

* Fix embed pages

* Attempt to fix flaky test

* Cleanup: explicitly register the last Angular component

* Move contents of /filters folder to /lib

* Remove unnecessary import

* Remove cy.wait from Parameters spec

Co-authored-by: Gabriel Dutra <[email protected]>

Co-authored-by: Levko Kravets <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend: React Frontend codebase migration to React Frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants