-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Query pages to React: cleanup #4512
Merged
kravets-levko
merged 11 commits into
migrate-query-source-view-to-react
from
migrate-query-source-view-to-react--cleanup
Jan 6, 2020
Merged
Migrate Query pages to React: cleanup #4512
kravets-levko
merged 11 commits into
migrate-query-source-view-to-react
from
migrate-query-source-view-to-react--cleanup
Jan 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kravets-levko
added
Frontend
Frontend: React
Frontend codebase migration to React
labels
Dec 30, 2019
kravets-levko
force-pushed
the
migrate-query-source-view-to-react--cleanup
branch
from
December 30, 2019 16:37
20c0027
to
0e9d1a6
Compare
kravets-levko
force-pushed
the
migrate-query-source-view-to-react--cleanup
branch
from
December 30, 2019 17:09
0e9d1a6
to
deaa1e2
Compare
kravets-levko
changed the title
Migrate Query pages to React: cleanup
(WIP) Migrate Query pages to React: cleanup
Dec 30, 2019
kravets-levko
force-pushed
the
migrate-query-source-view-to-react--cleanup
branch
from
December 31, 2019 10:57
466dab4
to
76461a8
Compare
kravets-levko
force-pushed
the
migrate-query-source-view-to-react--cleanup
branch
from
December 31, 2019 11:36
9342276
to
197e3e2
Compare
kravets-levko
force-pushed
the
migrate-query-source-view-to-react--cleanup
branch
from
December 31, 2019 11:37
197e3e2
to
2fdd34e
Compare
kravets-levko
changed the title
(WIP) Migrate Query pages to React: cleanup
Migrate Query pages to React: cleanup
Dec 31, 2019
27 tasks
…source-view-to-react--cleanup
gabrieldutra
approved these changes
Dec 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in code look good to me, so good to see so much going away 🚀. Most of all now is testing.
}, | ||
route.resolve | ||
); | ||
route.authenticated = route.authenticated !== false; // could be set to `false` do disable auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…source-view-to-react--cleanup
gabrieldutra
force-pushed
the
migrate-query-source-view-to-react--cleanup
branch
from
December 31, 2019 20:27
92cd95b
to
418ea7c
Compare
kravets-levko
force-pushed
the
migrate-query-source-view-to-react
branch
2 times, most recently
from
January 2, 2020 16:25
2d2c997
to
2934e53
Compare
kravets-levko
added a commit
that referenced
this pull request
Jan 6, 2020
* Migrate Query Source View page to React: skeleton * Sync QueryView and QuerySource (#4430) * Migrate schema browser to react (#4432) * Restyle code with Prettier * Migrate Query page to React: Save changes (#4452) * Migrate query source to React: Set of updates (#4457) * Migrate Query page to React: Visualization Tabs (#4453) Co-Authored-By: Levko Kravets <[email protected]> * Migrate Query Source page to React: Visualizations area (#4463) * Migrate Query page to React: Delete visualization button (#4461) * Migrate Query Source page to React: Visualization actions (#4467) * Migrate Query pages to React: Execute query hook (#4470) * Migrate Query Source page to React: Editor area (#4468) * Migrate Query Source page to React: metadata, schedule and description blocks (#4476) * Migrate Query page to React: Cancel query execution (#4496) * Migrate Query Source page to React: refine code (#4499) * Migrate Query Source page to React: alerts (#4504) * Migrate Query Source page to React: unsaved changes alert (#4505) * Migrate Query Source to React: resizable areas (v2) (#4503) * Migrate Query page to React: Query View (#4455) Co-authored-by: Levko Kravets <[email protected]> * Switch React and Angular versions of pages (until Angular version removed) * Migrate Query pages to React: fix permissions (#4506) * Migrate Query Source page to React: don't reload when saving new query (#4507) * Migrate Query pages to React: fix tests (#4509) * Use skipParametersDirtyFlag in executeQuery * Fix: cannot fork query from Query View page * Optimize query editor: handle query text changes faster * Revert "Optimize query editor: handle query text changes faster" This reverts commit 2934e53. * Reduce debounced time to 100 * Migrate Query pages to React: cleanup (#4512) * Migrate Query pages to React: cleanup * Further cleanup * Remove unused dependencies * Fix embed pages * Attempt to fix flaky test * Cleanup: explicitly register the last Angular component * Move contents of /filters folder to /lib * Remove unnecessary import * Remove cy.wait from Parameters spec Co-authored-by: Gabriel Dutra <[email protected]> Co-authored-by: Levko Kravets <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
#4429