Migrate Query Source page to React: metadata, schedule and description blocks #4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kravets-levko
added
Frontend
Frontend: React
…source-to-react--metadata
kravets-levko
commented
Dec 24, 2019
| .query-metadata-new.query-metadata-horizontal { | ||
| display: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
This block is the actual change, everything else is from Prettier
| @@ -0,0 +1,79 @@ | |||
| // ANGULAR_REMOVE_ME Change this class to `.query-metadata` when all related Angular code removed | |||
There was a problem hiding this comment.
Noticing it now, it's better if we keep .query-source-metadata here and .query-view-metadata for the view page to avoid conflicts.
There was a problem hiding this comment.
@gabrieldutra I changed implementation of QueryMetadata component so now it can display data source too (32bd46e). I temporarily added data source to Query Source page so you can try in on preview instance of this PR (I'll remove it before merging 🙂). It slightly differs from all existing variants, but not too much and IMO works good enough (check how it stacks on different screen widths)
There was a problem hiding this comment.
Cool, it looks it can be applied in the View page with no issues 👍
gabrieldutra
approved these changes
Dec 25, 2019
kravets-levko
force-pushed
the
migrate-query-source-to-react--metadata
branch
from
32bd46e
to
8a1b08a
Compare
kravets-levko
added a commit
that referenced
this pull request
Jan 6, 2020
* Migrate Query Source View page to React: skeleton * Sync QueryView and QuerySource (#4430) * Migrate schema browser to react (#4432) * Restyle code with Prettier * Migrate Query page to React: Save changes (#4452) * Migrate query source to React: Set of updates (#4457) * Migrate Query page to React: Visualization Tabs (#4453) Co-Authored-By: Levko Kravets <[email protected]> * Migrate Query Source page to React: Visualizations area (#4463) * Migrate Query page to React: Delete visualization button (#4461) * Migrate Query Source page to React: Visualization actions (#4467) * Migrate Query pages to React: Execute query hook (#4470) * Migrate Query Source page to React: Editor area (#4468) * Migrate Query Source page to React: metadata, schedule and description blocks (#4476) * Migrate Query page to React: Cancel query execution (#4496) * Migrate Query Source page to React: refine code (#4499) * Migrate Query Source page to React: alerts (#4504) * Migrate Query Source page to React: unsaved changes alert (#4505) * Migrate Query Source to React: resizable areas (v2) (#4503) * Migrate Query page to React: Query View (#4455) Co-authored-by: Levko Kravets <[email protected]> * Switch React and Angular versions of pages (until Angular version removed) * Migrate Query pages to React: fix permissions (#4506) * Migrate Query Source page to React: don't reload when saving new query (#4507) * Migrate Query pages to React: fix tests (#4509) * Use skipParametersDirtyFlag in executeQuery * Fix: cannot fork query from Query View page * Optimize query editor: handle query text changes faster * Revert "Optimize query editor: handle query text changes faster" This reverts commit 2934e53. * Reduce debounced time to 100 * Migrate Query pages to React: cleanup (#4512) * Migrate Query pages to React: cleanup * Further cleanup * Remove unused dependencies * Fix embed pages * Attempt to fix flaky test * Cleanup: explicitly register the last Angular component * Move contents of /filters folder to /lib * Remove unnecessary import * Remove cy.wait from Parameters spec Co-authored-by: Gabriel Dutra <[email protected]> Co-authored-by: Levko Kravets <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Tickets & Documents
#4429