Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Digest (30 December, 2019 - 6 January, 2020) #4523

Closed
weekly-digest bot opened this issue Jan 6, 2020 · 0 comments
Closed

Weekly Digest (30 December, 2019 - 6 January, 2020) #4523

weekly-digest bot opened this issue Jan 6, 2020 · 0 comments

Comments

@weekly-digest
Copy link

weekly-digest bot commented Jan 6, 2020

Here's the Weekly Digest for getredash/redash:


ISSUES

Last week 14 issues were created.
Of these, 8 issues have been closed and 6 issues are still open.

OPEN ISSUES

💚 #4521 Nuke Celery, by rauchy
💚 #4520 Special characters in Data Source passwords are not parsed correctly, by Talon876
💚 #4515 Hitting "Cancel" on "Are you sure?" box bugs out the interface, by susodapop
💚 #4514 Scheduled query executions fail when a query uses dynamic date range parameters, by susodapop
💚 #4513 Add warning for alerts with parameterized queries , by susodapop
💚 #4512 Migrate Query pages to React: cleanup, by kravets-levko

CLOSED ISSUES

❤️ #4522 Restyle Nuke Celery, by restyled-io[bot]
❤️ #4519 Can't schedule parameterized queries against the Query Results data source, by susodapop
❤️ #4518 Add error boundary to catch errors in visualizations, by kravets-levko
❤️ #4517 Restyle (WIP) Migrate Query pages to React: cleanup, by restyled-io[bot]
❤️ #4516 Fix: don't try to access message property of an exception, by arikfr
❤️ #4511 Restyle Run prettier on cypress folder, by restyled-io[bot]
❤️ #4510 Run prettier on cypress folder, by gabrieldutra
❤️ #4509 Migrate Query pages to React: fix tests, by kravets-levko

NOISY ISSUE

🔈 #4510 Run prettier on cypress folder, by gabrieldutra
It received 2 comments.


PULL REQUESTS

Last week, 14 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 5 pull requests were updated.
💛 #4512 Migrate Query pages to React: cleanup, by kravets-levko
💛 #4497 Replace $http with axios, by gabrieldutra
💛 #4494 Show error origin, by rauchy
💛 #4429 Migrate Query pages to React, by gabrieldutra
💛 #4391 New Elasticsearch query runner, by NicolasLM

MERGED PULL REQUEST

Last week, 9 pull requests were merged.
💜 #4522 Restyle Nuke Celery, by restyled-io[bot]
💜 #4516 Fix: don't try to access message property of an exception, by arikfr
💜 #4510 Run prettier on cypress folder, by gabrieldutra
💜 #4509 Migrate Query pages to React: fix tests, by kravets-levko
💜 #4498 Fix: properly encode UTF-8 filenames in query results request, by arikfr
💜 #4492 Refine permissions usage in Redash to allow for guest users, by arikfr
💜 #4491 Visualization Embed: Add option to hide timestamp, by arikfr
💜 #4413 Execute Queries in RQ, by rauchy
💜 #4371 Multiprocess RQ workers (using supervisor), by rauchy


COMMITS

Last week there were 7 commits.
🛠️ [Multiprocess RQ workers (using supervisor) (#4371) * launch and monitor multiple workers using supervisor

This reverts commit 13d4396.](29582e3) by gabrieldutra
🛠️ [Execute Queries in RQ (#4413) * enforce hard limits on non-responsive work horses by workers

  • move differences from Worker to helper methods to help make the specialization clearer

  • move HardLimitingWorker to redash/tasks

  • move schedule.py to /tasks

  • explain the motivation for HardLimitingWorker

  • pleasing CodeClimate

  • pleasing CodeClimate

  • port query execution to RQ

  • get rid of argsrepr

  • avoid star imports

  • allow queries to be cancelled in RQ

  • return QueryExecutionErrors as job results

  • fix TestTaskEnqueue and QueryExecutorTests

  • remove Celery monitoring

  • get rid of QueryTask and use RQ jobs directly (with a job serializer)

  • Revert "remove Celery monitoring"

This reverts commit 37a74ea.

  • reduce occurences of the word 'task'

  • use Worker, Queue and Job instead of spreading names that share behavior details

  • remove locks for failed jobs as well

  • did I not commit that colon? oh my

  • push the redis connection to RQ's stack on every request to avoid verbose connection setting

  • use a connection context for tests

  • black it up

  • run RQ on all queues when running in Cypress](329e859) by rauchy
    🛠️ [Fix: properly encode UTF-8 filenames in query results request (Fix: properly encode UTF-8 filenames in query results request #4498) * Fix: properly encode UTF-8 filenames in query results request

Ended up copying the implementation from Flask's send_file helper function, because send_file doesn't really fit our use case.

  • Update tests/handlers/test_query_results.py

Co-Authored-By: Omer Lachish [email protected]

Co-authored-by: Omer Lachish [email protected]](ff34ded) by arikfr
🛠️ Viz Embed: Add option to hide timestamp (#4491) by arikfr
🛠️ [Refine permissions usage in Redash to allow for guest users (#4492) * Allow executing query with either view_query or execute_query permissions.

  • Render AuthHeader according to permissions.

  • Don't return dashboards where you only have access to textbox widget.

Closes #4099.](30bc1e2) by arikfr


CONTRIBUTORS

Last week there were 3 contributors.
👤 rauchy
👤 arikfr
👤 gabrieldutra


STARGAZERS

Last week there were 35 stagazers.
WingsGo
wenxuyang
15936909
junguoguo
alcidesmorales
ambakshi
JUSTIN-BOLAND
zxm679
qcl999
mghasemi
aatimofeev
KokosnussDEV
bradbatt
jrbury
Remember2015
yuchou87
Rmember
kdkaergaard
dimitryslavin
tobiasbu
sth-fish
dharmavir
BreathL
Jeongsanghun
zhujin19
insomina
anggiejuli
Talon876
nakamasato
saiKumarGanji
jlVidal
isll
cocoonkid
randy-daratan
brucedesa
You all are the stars! 🌟


RELEASES

Last week there were no releases.


That's all for last week, please 👀 Watch and Star the repository getredash/redash to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant