Nuke Celery #4521
Merged
Nuke Celery #4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 13, 2019 22:59
Merged
|
@rauchy For sure I’ll take a look tomorrow when I’m back at the computer. I’m happy to provide code to replace the periodic tasks with RQ ones, this is a pretty important API for us. Thanks for reaching out! |
|
@jezdez great, thank you! If you don't mind, I think it might be better to submit it as a standalone PR. |
arikfr
reviewed
Jan 6, 2020
|
|
||
| return json_response(response) | ||
|
|
||
|
|
||
| @routes.route("/api/admin/queries/rq_status", methods=["GET"]) |
There was a problem hiding this comment.
Maybe we should switch the URLs not to leak the implementation detail (RQ) now that it's only RQ?
| @@ -18,9 +14,6 @@ | |||
| redis_connection, | |||
| rq_redis_connection, | |||
| ) | |||
| from redash.metrics import celery as celery_metrics # noqa | |||
There was a problem hiding this comment.
Need to remove redash/metrics/celery.py as well.
|
@rauchy in your opinion, anything blocking us from merging this? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Following #4413, we're 100% on RQ. This PR is strictly cleanup.
@jezdez - I'd love to get some context / suggestions from you regarding how to proceed with the periodic tasks. I didn't mean to be rude when I deleted them in this PR, I just wanted to remove as much as possible.
Related Tickets & Documents
#4413 #4092