Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting "Cancel" on "Are you sure?" box bugs out the interface #4515

Open
susodapop opened this issue Dec 30, 2019 · 1 comment
Open

Hitting "Cancel" on "Are you sure?" box bugs out the interface #4515

susodapop opened this issue Dec 30, 2019 · 1 comment
Labels

Comments

@susodapop
Copy link
Contributor

Issue Summary

Users on a laptop who accidentally make a "back" gesture can lose work because of this bug.

Steps to Reproduce

  1. Click "New Query" from the New menu
  2. Write a query (don't execute it).
  3. Hit the back button in your browser
  4. When prompted about losing changes, hit "Cancel"
  5. Observe the interface shrinks, the query disappears

The behavior is unpredictably different. Sometimes the interface shrinks but the query is still there, just near-impossible to see. Other times the "Page Back" operation proceeds normally and the query is just gone. In rare instances I've had the entire page crash and show a generic "Couldn't find that page" error. I can't get this to reproduce, however.

Oddly, executing a query without saving it does sometimes avoid this behavior. Not always, however.

Pictures

Query Screen with a new query

cancel dialogue

After clicking cancel

Technical details:

  • Redash Version: v9 Alpha
  • Browser/OS: FF / Chrome / Safari
  • How did you install Redash: SaaS
@arikfr
Copy link
Member

arikfr commented Dec 31, 2019

It's SaaS only issue because we use a fork of the AppView component there that we never fixed this issue in. It will be resolved as part of the React migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants