fix: Calculate liquidation price from opposite direction if the position is reduced #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzeis
force-pushed
the
fix/liquidity-price-calculation
branch
from
9c0a78d
to
39a194a
Compare
luckysori
approved these changes
Apr 22, 2024
bonomat
reviewed
Apr 22, 2024
bonomat
reviewed
Apr 22, 2024
holzeis
force-pushed
the
fix/liquidity-price-calculation
branch
from
59eafde
to
63cd49e
Compare
This is already checked in the calculate liquidation price function.
If a value is entered that would close the position, there is no liquidation price. Hence we simply show n/a.
The margin would anyways always be 0 sats.
Since the total is only the margin, this would always be 0 sats.
holzeis
force-pushed
the
fix/liquidity-price-calculation
branch
from
63cd49e
to
2e5552d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2403
Additionally I reworked the confirmation screen a bit. Nothing fundamental, but tweaked a little bit what information is shown depending on the corresponding trade action.
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-22.at.16.45.18.mp4