Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Calculate liquidation price from opposite direction if the position is reduced #2459

Merged
merged 10 commits into from
Apr 23, 2024
Merged

fix: Calculate liquidation price from opposite direction if the position is reduced #2459

merged 10 commits into from
Apr 23, 2024

Commits on Apr 23, 2024

  1. chore: Remove redundant null check 

    This is already checked in the calculate liquidation price function.
    @holzeis
    holzeis committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    356283e View commit details
    Browse the repository at this point in the history

  2. fix: Calculate liquidation price from opposite direction if the posit… 

    …ion is reduced
    @holzeis
    holzeis committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1c47e10 View commit details
    Browse the repository at this point in the history

  3. feat: Add quantity on confirmation dialog

    @holzeis
    holzeis committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    20c97e9 View commit details
    Browse the repository at this point in the history

  4. chore: Increase close position modal height

    @holzeis
    holzeis committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    cce67a6 View commit details
    Browse the repository at this point in the history

  5. fix: Show n/a liquidation price if position gets closed 

    If a value is entered that would close the position, there is no liquidation price. Hence we simply show n/a.
    @holzeis
    holzeis committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0747fd0 View commit details
    Browse the repository at this point in the history

  6. feat: Adapt order confirmation text according to trade action

    @holzeis
    holzeis committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f43b359 View commit details
    Browse the repository at this point in the history

  7. feat: Show unrealized pnl when position is closed, reduced or changin… 

    …g direction
    @holzeis
    holzeis committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9df6ef5 View commit details
    Browse the repository at this point in the history

  8. feat: Omit margin if the position is reduced 

    The margin would anyways always be 0 sats.
    @holzeis
    holzeis committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6392758 View commit details
    Browse the repository at this point in the history

  9. feat: Omit total when position is reduced 

    Since the total is only the margin, this would always be 0 sats.
    @holzeis
    holzeis committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9cc43ea View commit details
    Browse the repository at this point in the history

  10. docs: Improve open quantity documentation

    @holzeis
    holzeis committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    2e5552d View commit details
    Browse the repository at this point in the history