Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liquidation price on resize is calculated wrongly #2403

Closed
bonomat opened this issue Apr 11, 2024 · 0 comments · Fixed by #2459
Closed

Liquidation price on resize is calculated wrongly #2403

bonomat opened this issue Apr 11, 2024 · 0 comments · Fixed by #2459
Assignees
@holzeis
Labels
bug Something isn't working UI

Comments

@bonomat
Copy link
Contributor

bonomat commented Apr 11, 2024 •
edited
Loading

When resizing the position we get confronted with a confirmation dialog showing

  • margin
  • liquidation price
  • order matching fee

The liquidation price seems to be based on the new order, not on the updated position

in the screenshot below I had

  • 100 long , @ $100k
  • then go 50 short @ $100k

Afaik the liquidation price here is based on 50 short @ 100k and not at the remaining 50 long

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@holzeis holzeis

Labels
bug Something isn't working UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Calculate liquidation price from opposite direction if the position is reduced get10101/10101
2 participants
@bonomat @holzeis