-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9163 fixing a bug of change 3D Tiles height offset with Google 3D tiles #9421
Merged
allyoucanmap
merged 2 commits into
geosolutions-it:master
from
mahmoudadel54:issue_9163
Sep 11, 2023
Merged
#9163 fixing a bug of change 3D Tiles height offset with Google 3D tiles #9421
allyoucanmap
merged 2 commits into
geosolutions-it:master
from
mahmoudadel54:issue_9163
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…change a height offset value for google 3D tiles
mahmoudadel54
added
bug
Internal
Good first issue
3D
All issues related to the 3D rendering in CesiumJs
labels
Sep 8, 2023
1 task
allyoucanmap
approved these changes
Sep 11, 2023
@ElenaGallo please test this fix in dev and let us know if we can backport to 2023.02.xx, thanks |
tdipisa
added
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Sep 11, 2023
Test passed, @mahmoudadel54 please backport this PR to 2023.02.xx, thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Sep 14, 2023
MV88
pushed a commit
that referenced
this pull request
Sep 15, 2023
ElenaGallo
removed
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Sep 15, 2023
dsuren1
added a commit
to dsuren1/MapStore2
that referenced
this pull request
Sep 20, 2023
…notation * commit 'bed88971c58ab68dbfb33183eacaef8481fd0954': Adding clause in documentation for google photorealistic 3D tiles (geosolutions-it#9458) (geosolutions-it#9460) geosolutions-it#9275 Fix issue Invalid date on Firefox (geosolutions-it#9393) (geosolutions-it#9451) geosolutions-it#9163 Bug 3D Tiles offset with Google 3D tiles (geosolutions-it#9421) (geosolutions-it#9450) geosolutions-it#9269 fix issue of correct map embed url in sharing map (geosolutions-it#9395) (geosolutions-it#9452) geosolutions-it#9310 Annotation not works with sideBarmenu (geosolutions-it#9402) (geosolutions-it#9449) set resolve.fallback.http/https/zlib to false in webpack extension build config (geosolutions-it#9375) (geosolutions-it#9445) geosolutions-it#9422 Zoom level issue on OpenLayers (geosolutions-it#9429) (geosolutions-it#9442) geosolutions-it#9362 3D Styling issue (geosolutions-it#9403) (geosolutions-it#9441) geosolutions-it#9363 Wrong scale value reported using the scroll wheel (geosolutions-it#9401) (geosolutions-it#9440) geosolutions-it#9366 Problems with Bearing measurement (geosolutions-it#9400) (geosolutions-it#9439) geosolutions-it#9346 ensure the zoom is always round before using it as index (geosolutions-it#9357) (geosolutions-it#9438)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing the issue of throwing an unhandled error in case change the 3D tiles height offset with Google 3D tiles.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#9163
What is the current behavior?
#9163
What is the new behavior?
If a user opens google 3D tiles and set a height offset it will reflect on map and no error is thrown.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information