Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9163 fixing a bug of change 3D Tiles height offset with Google 3D tiles #9421

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

mahmoudadel54
Copy link
Contributor

Description

Fixing the issue of throwing an unhandled error in case change the 3D tiles height offset with Google 3D tiles.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

#9163
What is the current behavior?
#9163

What is the new behavior?
If a user opens google 3D tiles and set a height offset it will reflect on map and no error is thrown.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

…change a height offset value for google 3D tiles
@mahmoudadel54 mahmoudadel54 added bug Internal Good first issue 3D All issues related to the 3D rendering in CesiumJs labels Sep 8, 2023
@mahmoudadel54 mahmoudadel54 added this to the 2023.02.00 milestone Sep 8, 2023
@mahmoudadel54 mahmoudadel54 self-assigned this Sep 8, 2023
@mahmoudadel54 mahmoudadel54 linked an issue Sep 8, 2023 that may be closed by this pull request
1 task
@allyoucanmap allyoucanmap merged commit b6506f3 into geosolutions-it:master Sep 11, 2023
@allyoucanmap
Copy link
Contributor

@ElenaGallo please test this fix in dev and let us know if we can backport to 2023.02.xx, thanks

@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 11, 2023
@ElenaGallo
Copy link
Contributor

Test passed, @mahmoudadel54 please backport this PR to 2023.02.xx, thanks

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this pull request Sep 14, 2023
@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 15, 2023
dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Sep 20, 2023
…notation

* commit 'bed88971c58ab68dbfb33183eacaef8481fd0954':
  Adding clause in documentation for google photorealistic 3D tiles (geosolutions-it#9458) (geosolutions-it#9460)
  geosolutions-it#9275 Fix issue Invalid date on Firefox  (geosolutions-it#9393) (geosolutions-it#9451)
  geosolutions-it#9163 Bug 3D Tiles offset with Google 3D tiles (geosolutions-it#9421) (geosolutions-it#9450)
  geosolutions-it#9269 fix issue of correct map embed url in sharing map (geosolutions-it#9395) (geosolutions-it#9452)
  geosolutions-it#9310 Annotation not works with sideBarmenu (geosolutions-it#9402) (geosolutions-it#9449)
  set resolve.fallback.http/https/zlib to false in webpack extension build config (geosolutions-it#9375) (geosolutions-it#9445)
  geosolutions-it#9422 Zoom level issue on OpenLayers (geosolutions-it#9429) (geosolutions-it#9442)
  geosolutions-it#9362 3D Styling issue (geosolutions-it#9403) (geosolutions-it#9441)
  geosolutions-it#9363 Wrong scale value reported using the scroll wheel (geosolutions-it#9401) (geosolutions-it#9440)
  geosolutions-it#9366 Problems with Bearing measurement (geosolutions-it#9400) (geosolutions-it#9439)
  geosolutions-it#9346 ensure the zoom is always round before using it as index (geosolutions-it#9357) (geosolutions-it#9438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D All issues related to the 3D rendering in CesiumJs bug Good first issue Internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug 3D Tiles offset with Google 3D tiles
4 participants