Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map embed url is not correct #9269

Closed
1 task done
allyoucanmap opened this issue Jul 4, 2023 · 0 comments · Fixed by #9395 or #9452
Closed
1 task done

Map embed url is not correct #9269

allyoucanmap opened this issue Jul 4, 2023 · 0 comments · Fixed by #9395 or #9452
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted bug C027-COMUNE_FI-2023-SUPPORT Good first issue Regression
Milestone
2023.02.00

Comments

@allyoucanmap
Copy link
Contributor

Description

The map embed link should point to:

  • /embedded.html#/{mapId}

but currently is pointing to the map viewer

  • /#/viewer/{mapId}

image

How to reproduce

  • go to the homepage or inside a map
  • click on the share button of the map card or from the side bar inside the map viewer
  • select the embed tab

Expected Result

  • the embed url should point to the correct html page

Current Result

  • the embed url is the map viewer page

  • Not browser related

Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@allyoucanmap allyoucanmap added this to the 2023.02.00 milestone Jul 4, 2023
@tdipisa tdipisa self-assigned this Aug 21, 2023
@tdipisa tdipisa assigned mahmoudadel54 and unassigned tdipisa Sep 4, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 6, 2023
@mahmoudadel54
geosolutions-it#9269 fix map embed url in sharing map
fe5f527
@mahmoudadel54 mahmoudadel54 mentioned this issue Sep 6, 2023
Merged
5 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 6, 2023
@mahmoudadel54
geosolutions-it#9269 add test case for embed url of map
84693fd
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 6, 2023
@mahmoudadel54
Revert "geosolutions-it#9269 fix map embed url in sharing map"
0c6f3e6 
This reverts commit fe5f527.
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 6, 2023
@mahmoudadel54
geosolutions-it#9269 fix map embed url in sharing map with test case
4d6d291
@mahmoudadel54 mahmoudadel54 linked a pull request Sep 7, 2023 that will close this issue
#9269 fix issue of correct map embed url in sharing map #9395
Merged
5 tasks
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 11, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 11, 2023
@mahmoudadel54
geosolutions-it#9269: resolve comment, make edit in the regex of shar…
a2d1275 
…ing map viewer
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 11, 2023
@mahmoudadel54
geosolutions-it#9269: remove typo from shaprepanel test file
24fed0b
allyoucanmap pushed a commit that referenced this issue Sep 11, 2023
@mahmoudadel54
#9269 fix issue of correct map embed url in sharing map (#9395)
587287b
@ElenaGallo ElenaGallo self-assigned this Sep 12, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 14, 2023
@mahmoudadel54
geosolutions-it#9269 fix issue of correct map embed url in sharing map (
7416e0a 
geosolutions-it#9395)
@mahmoudadel54 mahmoudadel54 mentioned this issue Sep 14, 2023
Merged
5 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Sep 14, 2023 that will close this issue
[Backport 2023.02.xx] #9269 fix issue of correct map embed url in sharing map (#9395) #9452
Merged
5 tasks
MV88 pushed a commit that referenced this issue Sep 14, 2023
@mahmoudadel54
#9269 fix issue of correct map embed url in sharing map (#9395) (#9452)
7b5742c
@ElenaGallo ElenaGallo added Accepted and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Sep 14, 2023
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Sep 20, 2023
@dsuren1
Merge commit 'bed88971c58ab68dbfb33183eacaef8481fd0954' into #9319_an…
cfe5537 
…notation

* commit 'bed88971c58ab68dbfb33183eacaef8481fd0954':
  Adding clause in documentation for google photorealistic 3D tiles (geosolutions-it#9458) (geosolutions-it#9460)
  geosolutions-it#9275 Fix issue Invalid date on Firefox  (geosolutions-it#9393) (geosolutions-it#9451)
  geosolutions-it#9163 Bug 3D Tiles offset with Google 3D tiles (geosolutions-it#9421) (geosolutions-it#9450)
  geosolutions-it#9269 fix issue of correct map embed url in sharing map (geosolutions-it#9395) (geosolutions-it#9452)
  geosolutions-it#9310 Annotation not works with sideBarmenu (geosolutions-it#9402) (geosolutions-it#9449)
  set resolve.fallback.http/https/zlib to false in webpack extension build config (geosolutions-it#9375) (geosolutions-it#9445)
  geosolutions-it#9422 Zoom level issue on OpenLayers (geosolutions-it#9429) (geosolutions-it#9442)
  geosolutions-it#9362 3D Styling issue (geosolutions-it#9403) (geosolutions-it#9441)
  geosolutions-it#9363 Wrong scale value reported using the scroll wheel (geosolutions-it#9401) (geosolutions-it#9440)
  geosolutions-it#9366 Problems with Bearing measurement (geosolutions-it#9400) (geosolutions-it#9439)
  geosolutions-it#9346 ensure the zoom is always round before using it as index (geosolutions-it#9357) (geosolutions-it#9438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
Accepted bug C027-COMUNE_FI-2023-SUPPORT Good first issue Regression
Projects
None yet
Milestone
2023.02.00
4 participants
@tdipisa @allyoucanmap @ElenaGallo @mahmoudadel54