#9346 ensure the zoom is always round before using it as index #9357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
offtherailz
approved these changes
Sep 5, 2023
ElenaGallo
added
the
BackportNeeded
|
Test passed, @allyoucanmap please backport this to stable branch. Thanks |
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this pull request
Sep 13, 2023
allyoucanmap
removed
the
BackportNeeded
tdipisa
pushed a commit
that referenced
this pull request
Sep 14, 2023
dsuren1
added a commit
to dsuren1/MapStore2
that referenced
this pull request
Sep 20, 2023
…notation * commit 'bed88971c58ab68dbfb33183eacaef8481fd0954': Adding clause in documentation for google photorealistic 3D tiles (geosolutions-it#9458) (geosolutions-it#9460) geosolutions-it#9275 Fix issue Invalid date on Firefox (geosolutions-it#9393) (geosolutions-it#9451) geosolutions-it#9163 Bug 3D Tiles offset with Google 3D tiles (geosolutions-it#9421) (geosolutions-it#9450) geosolutions-it#9269 fix issue of correct map embed url in sharing map (geosolutions-it#9395) (geosolutions-it#9452) geosolutions-it#9310 Annotation not works with sideBarmenu (geosolutions-it#9402) (geosolutions-it#9449) set resolve.fallback.http/https/zlib to false in webpack extension build config (geosolutions-it#9375) (geosolutions-it#9445) geosolutions-it#9422 Zoom level issue on OpenLayers (geosolutions-it#9429) (geosolutions-it#9442) geosolutions-it#9362 3D Styling issue (geosolutions-it#9403) (geosolutions-it#9441) geosolutions-it#9363 Wrong scale value reported using the scroll wheel (geosolutions-it#9401) (geosolutions-it#9440) geosolutions-it#9366 Problems with Bearing measurement (geosolutions-it#9400) (geosolutions-it#9439) geosolutions-it#9346 ensure the zoom is always round before using it as index (geosolutions-it#9357) (geosolutions-it#9438)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes the zoom level is to round also inside 2D map, with this PR we ensure the zoom is round when it is used as array index. The Print plugin was using reprojectZoom that was failing when the zoom level had decimals
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#9346
What is the new behavior?
Print plugin is working also after zoom in or out
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
see #9346 (comment)