Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Decidim to v0.27 #490

Merged
merged 85 commits into from
Oct 21, 2024
Merged

Upgrade Decidim to v0.27 #490

merged 85 commits into from
Oct 21, 2024

Conversation

laurajaime
Copy link
Collaborator

@laurajaime laurajaime commented Jul 11, 2024

🎩 What? Why?

Upgrade Decidim to v0.27

Release notes: https://github.com/CodiTramuntana/decidim/blob/release/0.27-stable/CHANGELOG.md

In this version, participatory processes has type. We have a custom module for that (decidim-type) but is not necessary anymore, so we remove the custom module.

FIXES

  • Add translation in upload file in private users in processes (The same has been done as for other uploads, for example, import process)
    Example in other modal
    Screenshot from 2024-09-12 14-04-41
    Fix
    image

TO-DO

  • Remove decidim-type and rework participatory processes

Related PRs:

📷 Screenshots (optional)

image

Copy link
Collaborator

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test? can we document exactly what are we changing from the original class?
Can we use a decorator instead of overriding the whole class?

Comment on lines 131 to 133
def url
Decidim::ResourceLocatorPresenter.new(process).url&.split("?")&.first
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you document why we need this? Process URLs don't have query parameters no?

@tramuntanal tramuntanal merged commit 413e305 into master Oct 21, 2024
6 checks passed
@tramuntanal tramuntanal deleted the upgrade/0.27 branch October 21, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants