Upgrade to Decidim v0.27 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
laurajaime
commented
Jul 16, 2024
•
laurajaime
commented
- Upgrade Ruby to 3.0.7
- Upgrade Node to 16.9.1
- Refactor override to decorator
- Changes related to upgrade in decorators and views
- Upgrade Ruby version in GH workflow
- Add chromedriver workaround
- Fix system tests
4 tasks
laurajaime
force-pushed
the
upgrade/0.27
branch
4 times, most recently
from
fb599fd to
5048aa7
Compare
tramuntanal
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Good work here @laurajaime !
I have found some things to review before we mark it done
spec/system/department_admin_should_be_able_to_manage_assemblies_spec.rb
Show resolved
Hide resolved
There was a problem hiding this comment.
The README says in Temporal fix: added & in case role_name check. that, in theory, this decorator can be removed, no?
There was a problem hiding this comment.
haves you checked? what's the status of this?
There was a problem hiding this comment.
the decorator add department admin role too.
The & has not been put in the original file in decidim...so it has not been resolved and I have put this back in the README
laurajaime
force-pushed
the
upgrade/0.27
branch
5 times, most recently
from
a2a5810 to
ce3cc3a
Compare
laurajaime
force-pushed
the
upgrade/0.27
branch
from
ce3cc3a to
7c8133a
Compare
tramuntanal
reviewed
Aug 27, 2024
laurajaime
force-pushed
the
upgrade/0.27
branch
from
ec77e9f to
c5aed01
Compare
tramuntanal
reviewed
Aug 29, 2024
|
|
||
| RSpec.describe "Overrides" do | ||
| it "check failing tests in Decidim v0.28" do | ||
| # - spec/system/department_admin_should_be_able_to_manage_assemblies_spec.rb |
There was a problem hiding this comment.
# Make test succeed spec/system/department_admin_should_be_able_to_manage_assemblies_spec.rbL73
# expect(page).to have_current_path decidim_admin_assemblies.assemblies_path(q: { parent_id_eq: parent_assembly&.id })
c5aed01 to
ada9d30
Compare
tramuntanal
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.