Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/unified notification on proposes loaded massively #495

Merged

Conversation

ivan-mr
Copy link
Collaborator

@ivan-mr ivan-mr commented Sep 25, 2024

🎩 What? Why?

Replace notifying every proposal or answer to followers and notify the follower once time reporting all imported elements

📌 Related Issues

📋 Subtasks

  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

Screenshot of email send notifying proposals import
image

Screenshot of email send notifying answers proposals import
image

@ivan-mr ivan-mr changed the base branch from master to upgrade/0.27 September 25, 2024 09:00
Copy link
Collaborator

@laurajaime laurajaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! some comments to review

app/decorators/decidim/admin/import/importer_decorator.rb Outdated Show resolved Hide resolved
app/mailers/proposals_answers_mailer.rb Outdated Show resolved Hide resolved
app/mailers/proposals_answers_mailer.rb Outdated Show resolved Hide resolved
app/mailers/proposals_mailer.rb Outdated Show resolved Hide resolved
app/mailers/proposals_mailer.rb Outdated Show resolved Hide resolved
@ivan-mr ivan-mr merged commit 1a512be into upgrade/0.27 Oct 7, 2024
6 checks passed
@ivan-mr ivan-mr deleted the feat/unified_notification_on_proposes_loaded_massively branch October 7, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants