-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/unified notification on proposes loaded massively #495
Merged
ivan-mr
merged 12 commits into
upgrade/0.27
from
feat/unified_notification_on_proposes_loaded_massively
Oct 7, 2024
Merged
Feat/unified notification on proposes loaded massively #495
ivan-mr
merged 12 commits into
upgrade/0.27
from
feat/unified_notification_on_proposes_loaded_massively
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurajaime
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! some comments to review
app/views/proposals_answers_mailer/notify_massive_import.html.erb
Outdated
Show resolved
Hide resolved
spec/decorators/decidim/admin/import/importer_decorator_spec.rb
Outdated
Show resolved
Hide resolved
…s_loaded_massively
laurajaime
reviewed
Sep 25, 2024
spec/decorators/decidim/proposals/import/proposal_creator_decorator_spec.rb
Outdated
Show resolved
Hide resolved
ivan-mr
deleted the
feat/unified_notification_on_proposes_loaded_massively
branch
October 7, 2024 21:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Replace notifying every proposal or answer to followers and notify the follower once time reporting all imported elements
📌 Related Issues
📋 Subtasks
📷 Screenshots (optional)
Screenshot of email send notifying proposals import
Screenshot of email send notifying answers proposals import