-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add core_processor::prepare
method
#1211
Conversation
adjust to the change
the case when program's memory already has been loaded.
into gshep/issue-1088-2
cfbf941Pallet tests (values are in nanoseconds)Total execution time
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-gas
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-gear-scheduler
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Asynchronous recursion
name = Basic capacitor check
name = Chat
name = Decoder
name = Exit code
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program generator
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Vector
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
56bc6bePallet tests (values are in nanoseconds)Total execution time
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-gas
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-gear-scheduler
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Asynchronous recursion
name = Basic capacitor check
name = Chat
name = Decoder
name = Exit code
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program generator
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Vector
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
8fe5b5cPallet tests (values are in nanoseconds)Total execution time
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-gas
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-gear-scheduler
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Asynchronous recursion
name = Basic capacitor check
name = Chat
name = Decoder
name = Exit code
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program generator
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Vector
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
4dcf7b5Pallet tests (values are in nanoseconds)Total execution time
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-gas
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-gear-scheduler
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Asynchronous recursion
name = Basic capacitor check
name = Chat
name = Decoder
name = Exit code
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program generator
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Vector
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
59ab9d5Pallet tests (values are in nanoseconds)Total execution time
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-gas
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-gear-scheduler
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Asynchronous recursion
name = Basic capacitor check
name = Chat
name = Decoder
name = Exit code
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program generator
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Vector
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
2bdeb95Pallet tests (values are in nanoseconds)Total execution time
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-gas
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-gear-scheduler
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Asynchronous recursion
name = Basic capacitor check
name = Chat
name = Decoder
name = Exit code
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program generator
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Vector
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
|
Codecov Report
@@ Coverage Diff @@
## master #1211 +/- ##
==========================================
- Coverage 71.67% 67.36% -4.31%
==========================================
Files 108 108
Lines 10057 10847 +790
==========================================
+ Hits 7208 7307 +99
- Misses 2849 3540 +691
Help us with your feedback. Take ten seconds to tell us how you rate us. |
into gshep/issue-1088-2 Conflicts: gtest/src/manager.rs pallets/gear/src/lib.rs
into gshep/issue-1088-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM at all, but seems there is still place for refactoring and simplifications of aggregating data for future 👍
into gshep/issue-1088-2 Conflicts: runtime/src/lib.rs
@gshep, please, never resolve comments, before here any changes pushed |
into gshep/issue-1088-2 Conflicts: pallets/gear/src/benchmarking/mod.rs
into gshep/issue-1088-2
into gshep/issue-1088-2 Conflicts: runtime/src/lib.rs
into gshep/issue-1088-2 Conflicts: core-processor/src/processor.rs runtime/src/lib.rs
into gshep/issue-1088-2 Conflicts: core-processor/src/executor.rs gtest/src/manager.rs pallets/gear/src/benchmarking/mod.rs pallets/gear/src/lib.rs
into gshep/issue-1088-2 Conflicts: gear-test/src/check.rs runtime/src/lib.rs
Resolves #1088 , #1182
prepare
method. It checks if provided actor is executable, if code contains required export and tries to pre-charge for memory pagesprocess_executable
functioncalculate_gas_info
: addGasInfo::may_be_returned
if a program happens to be executed repeatedly in a block.Supersedes #1162 , #1183 .
@gear-tech/dev
@osipov-mit please also check this.